From: Marek Vasut <marex@denx.de>
To: linux-mtd@lists.infradead.org
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Angus Clark <angus.clark@st.com>,
Mike Dunn <mikedunn@newsguy.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
Huang Shijie <b32955@freescale.com>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 9/9] mtd: nand: detect Samsung K9GBG08U0A, K9GAG08U0F ID
Date: Fri, 5 Oct 2012 03:37:11 +0200 [thread overview]
Message-ID: <201210050337.12011.marex@denx.de> (raw)
In-Reply-To: <1348544455-17656-10-git-send-email-computersforpeace@gmail.com>
Dear Brian Norris,
> Datasheets for the following Samsung NAND parts (both MLC and SLC) describe
> extensions to the Samsung 6-byte extended ID decoding table:
[...]
This breaks my board with K9F2G08 part:
[ 0.860000] NAND device: Manufacturer ID: 0xec, Chip ID: 0xda (Samsung NAND
256MiB 3,3V 8-bit), page size: 2048, OOB size: 64
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 7e93d0d..bcb58ce 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2939,19 +2939,18 @@ static void nand_decode_ext_id(struct mtd_info
> *mtd, struct nand_chip *chip, /*
> * Field definitions are in the following datasheets:
> * Old style (4,5 byte ID): Samsung K9GAG08U0M (p.32)
> - * New style (6 byte ID): Samsung K9GBG08U0M (p.40)
> + * New style (6 byte ID): Samsung K9GAG08U0F (p.44)
> * Hynix MLC (6 byte ID): Hynix H27UBG8T2B (p.22)
> *
> * Check for ID length, cell type, and Hynix/Samsung ID to decide what
> * to do.
> */
> - if (id_len == 6 && id_data[0] == NAND_MFR_SAMSUNG &&
> - (chip->cellinfo & NAND_CI_CELLTYPE_MSK)) {
> + if (id_len == 6 && id_data[0] == NAND_MFR_SAMSUNG) {
[...]
I believe the above hunk is wrong, reverting it fixes the problem.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-05 1:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 3:40 [PATCH 0/9] mtd: nand: improve NAND ID detection Brian Norris
2012-09-25 3:40 ` [PATCH 1/9] mtd: nand: remove unnecessary variable Brian Norris
2012-09-25 3:40 ` [PATCH 2/9] mtd: nand: remove redundant ID read Brian Norris
2012-09-25 3:40 ` [PATCH 3/9] mtd: nand: split BB marker options decoding into its own function Brian Norris
2012-09-25 3:40 ` [PATCH 4/9] mtd: nand: split extended ID " Brian Norris
2012-09-25 3:40 ` [PATCH 5/9] mtd: nand: split simple ID decode " Brian Norris
2012-09-25 3:40 ` [PATCH 6/9] mtd: nand: add generic READ ID length calculation functions Brian Norris
2012-09-25 3:40 ` [PATCH 7/9] mtd: nand: increase max OOB size to 640 Brian Norris
2012-09-25 3:40 ` [PATCH 8/9] mtd: nand: decode Hynix MLC, 6-byte ID length Brian Norris
2012-09-25 3:40 ` [PATCH 9/9] mtd: nand: detect Samsung K9GBG08U0A, K9GAG08U0F ID Brian Norris
2012-10-05 1:37 ` Marek Vasut [this message]
2012-10-06 20:24 ` Brian Norris
2012-10-07 3:29 ` Marek Vasut
2012-09-27 12:23 ` [PATCH 0/9] mtd: nand: improve NAND ID detection Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210050337.12011.marex@denx.de \
--to=marex@denx.de \
--cc=angus.clark@st.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.