All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Marcin Kościelnicki" <koriakin-mP9o5jsk0RY@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/nouveau: fix early vram corruption originating from vgacon
Date: Fri, 5 Oct 2012 22:18:11 +0200	[thread overview]
Message-ID: <20121005201811.GC8531@joi.lan> (raw)
In-Reply-To: <506D768D.6050100-mP9o5jsk0RY@public.gmane.org>

On Thu, Oct 04, 2012 at 01:44:13PM +0200, Marcin Kościelnicki wrote:
> On 04.10.2012 13:35, Marcin Slusarz wrote:
> > On Thu, Sep 13, 2012 at 12:52:30AM +0200, Marcin Slusarz wrote:
> This (and corresponding unload line) is a bug: you should NOT blindly 
> set this register to 1 on unload, use its previous value instead. 
> Otherwise you can get into sticky situations involving two GPUs 
> responding to VGA address space. Better yet, think up a proper solution 
> involving vga arb.

Thanks to your comment I noticed two more things:
- I probably should have used dword API variant.
- There is already code in nouveau which bashes this register (nouveau_vga.c /
nouveau_vga_set_decode) and it's wired to vgaarb. It seems it's set to 0 only
when there is more than one card. I'm not sure how to handle it yet...

Marcin
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

      parent reply	other threads:[~2012-10-05 20:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 22:52 [PATCH] drm/nouveau: fix early vram corruption originating from vgacon Marcin Slusarz
     [not found] ` <20120912225230.GD8067-OI9uyE9O0yo@public.gmane.org>
2012-10-04 11:35   ` Marcin Slusarz
     [not found]     ` <20121004113515.GC4979-OI9uyE9O0yo@public.gmane.org>
2012-10-04 11:44       ` Marcin Kościelnicki
     [not found]         ` <506D768D.6050100-mP9o5jsk0RY@public.gmane.org>
2012-10-05 20:18           ` Marcin Slusarz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121005201811.GC8531@joi.lan \
    --to=marcin.slusarz-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=koriakin-mP9o5jsk0RY@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.