All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ml507: Fix Xilinx uartlite driver hang
Date: Fri, 5 Oct 2012 23:33:04 +0200	[thread overview]
Message-ID: <20121005233304.0c210c27@wker> (raw)
In-Reply-To: <loom.20120925T012211-749@post.gmane.org>

Hi,

On Mon, 24 Sep 2012 23:27:05 +0000 (UTC)
Rommel Custodio <sessyargc+uboot@gmail.com> wrote:

> The default configuration for ml507 will generate a hang() in the
> Xilinx uartlite driver.
> 
> userial_ports[] in drivers/serial/serial_xuartlite.c does not get
> initialized properly. CONFIG_SERIAL_BASE is unused.
> XILINX_UARTLITE_BASEADDR is used instead.
> 
> Signed-off-by: Rommel Custodio <sessyargc+uboot@gmail.com>
> ---
> Changes since v1:
>  - fixed the path, tabs got mangled causing the patch to fail
> 
>  include/configs/xilinx-ppc.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/xilinx-ppc.h b/include/configs/xilinx-ppc.h
> index 1235c37..2bdaa05 100644
> --- a/include/configs/xilinx-ppc.h
> +++ b/include/configs/xilinx-ppc.h
> @@ -118,7 +118,7 @@
>  /* serial communication */
>  #ifdef XPAR_UARTLITE_0_BASEADDR
>  #define CONFIG_XILINX_UARTLITE
> -#define CONFIG_SERIAL_BASE		XPAR_UARTLITE_0_BASEADDR
> +#define XILINX_UARTLITE_BASEADDR	XPAR_UARTLITE_0_BASEADDR
>  #define CONFIG_BAUDRATE			XPAR_UARTLITE_0_BAUDRATE
>  #define CONFIG_SYS_BAUDRATE_TABLE	{ CONFIG_BAUDRATE }
>  #else

I think this patch is correct. Applied to staging/agust at denx.de.

Thanks,
Anatolij

      reply	other threads:[~2012-10-05 21:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 23:27 [U-Boot] [PATCH v2] ml507: Fix Xilinx uartlite driver hang Rommel Custodio
2012-10-05 21:33 ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121005233304.0c210c27@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.