From: Al Viro <viro@ZenIV.linux.org.uk>
To: sparclinux@vger.kernel.org
Subject: Re: [RESEND PATCH 1/2] sparc64: Rearrange thread info to cheaply clear syscall noerror state.
Date: Sat, 06 Oct 2012 02:50:26 +0000 [thread overview]
Message-ID: <20121006025026.GE2616@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20121004.174812.706050126936137696.davem@davemloft.net>
On Fri, Oct 05, 2012 at 10:43:43PM -0400, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Sat, 6 Oct 2012 00:26:51 +0100
>
> > On Fri, Oct 05, 2012 at 05:48:42PM -0400, David Miller wrote:
> >>
> >> Al, this change turns out to be broken.
> >>
> >> If you move the WSAVED byte down past bit 16, it runs into the bit
> >> mask we for the _TI_* flag bits down lower in the file.
> >
> > Umm... Right you are. I wonder why I hadn't stepped into that while
> > testing that sucker...
>
> I tested it for 20 hours and didn't hit any problems, so don't feel
> bad. :-)
>
> > sparc64: clear syscall_noerror on the entry to syscall, not on the exit
> >
> > Move that sucker to just before TI_FPDEPTH and replace stb with sth in
> > etrap_save(). Take current_ds to its old place, so that we don't push
> > wsaved into TI_... flags. That allows to lose clearing syscall_noerror
> > on return from syscall.
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> I'll look at this later.
... when I send something that compiles and runs. My apologies; I still think
that solution in this direction can work, but that wasn't it.
next prev parent reply other threads:[~2012-10-06 2:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 21:48 [RESEND PATCH 1/2] sparc64: Rearrange thread info to cheaply clear syscall noerror state David Miller
2012-10-05 21:48 ` David Miller
2012-10-05 23:26 ` Al Viro
2012-10-06 2:43 ` David Miller
2012-10-06 2:50 ` Al Viro [this message]
2012-10-06 3:49 ` David Miller
2012-10-06 6:06 ` Al Viro
2012-10-08 19:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121006025026.GE2616@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.