Re: [Qemu-devel] [PATCH] qemu-barrier: Fix compilation on i386 hosts

[Aurelien Jarno <aurelien@aurel32.net>]

On Sat, Oct 06, 2012 at 12:46:15PM +0200, Stefan Weil wrote:
> Commit 610b823ef66b993660f1ab1447a769f190e4f3b3 uses QEMU_GNUC_PREREQ
> on i386 hosts.
> 
> That macro is defined in qemu-common.h which is not always included
> before qemu-barrier.h, so compilation on i386 hosts was broken.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> This patch fixes broken compilation for i386 hosts which
> was reported by the buildbot:
> 
> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/396
> 
> Regards
> 
> Stefan Weil
> 
>  qemu-barrier.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/qemu-barrier.h b/qemu-barrier.h
> index 16f0942..1de914e 100644
> --- a/qemu-barrier.h
> +++ b/qemu-barrier.h
> @@ -6,6 +6,8 @@
>  
>  #if defined(__i386__)
>  
> +#include "qemu-common.h"        /* QEMU_GNUC_PREREQ */
> +
>  /*
>   * Because of the strongly ordered x86 storage model, wmb() and rmb() are nops
>   * on x86(well, a compiler barrier only).  Well, at least as long as
> -- 
> 1.7.10
> 

Thanks, applied.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net