From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow generating a non-default set of documentation
Date: Sun, 7 Oct 2012 19:01:02 -0400 [thread overview]
Message-ID: <20121007230102.GB3490@sigill.intra.peff.net> (raw)
In-Reply-To: <7vsj9poq8v.fsf@alter.siamese.dyndns.org>
On Sun, Oct 07, 2012 at 03:45:52PM -0700, Junio C Hamano wrote:
> So here is a proposed update based on your idea, to be squashed on
> top (i.e. the change to the top-level Makefile in the posted patch
> is not reverted).
>
> Does it make sense?
The change to Documentation/Makefile makes sense, but what then is the
point of the second half of this hunk from your original:
@@ -2468,10 +2476,10 @@ $(XDIFF_LIB): $(XDIFF_OBJS)
$(VCSSVN_LIB): $(VCSSVN_OBJS)
$(QUIET_AR)$(RM) $@ && $(AR) rcs $@ $(VCSSVN_OBJS)
-export DEFAULT_EDITOR DEFAULT_PAGER
+export DEFAULT_EDITOR DEFAULT_PAGER DEFAULT_DOC_TARGET
doc:
- $(MAKE) -C Documentation all
+ $(MAKE) -C Documentation $(DEFAULT_DOC_TARGET)
man:
$(MAKE) -C Documentation man
We know that "all" is simply a redirect to DEFAULT_DOC_TARGET internally
within the documentation Makefile, and we know that it is propagated by
the export line above. I do not think it creates the wrong behavior,
but it is unnecessary, and omitting a target at all demonstrates to a
reader how they can get the same behavior from within Documentation
(namely by running just "make").
-Peff
next prev parent reply other threads:[~2012-10-07 23:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 20:39 [PATCH] Allow generating a non-default set of documentation Junio C Hamano
2012-10-07 21:48 ` Jeff King
2012-10-07 22:32 ` Junio C Hamano
2012-10-07 22:45 ` Junio C Hamano
2012-10-07 23:01 ` Jeff King [this message]
2012-10-07 22:40 ` Junio C Hamano
2012-10-07 23:07 ` Jeff King
2012-10-07 23:11 ` Jeff King
2012-10-07 23:25 ` Junio C Hamano
2012-10-07 23:29 ` Jeff King
2012-10-07 23:44 ` Junio C Hamano
2012-10-08 16:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121007230102.GB3490@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.