From: Marek Vasut <marex@denx.de>
To: "Grégor Boirie" <gregor.boirie@parrot.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] mtd: m25p80: fix missing MTD module owner
Date: Mon, 8 Oct 2012 15:09:44 +0200 [thread overview]
Message-ID: <201210081509.44802.marex@denx.de> (raw)
In-Reply-To: <50728A5E.3020102@parrot.com>
Dear Grégor Boirie,
> Marek,
>
> Sorry about that. I didn't really mean to submit an official patch at
> first...
No no, nothing to be sorry about actually, we're really grateful you spotted the
issue and reported it!
> Nevermind, please find one just below.
Actually, can you try one more time and after commiting the change to your local
git tree, do "git send-email --to="linux-mtd@lists.infradead.org" HEAD~1"
please?
Also, it is a good idea to add "Cc: Name Surname <e@ma.il>" lines to the patch
description just before the Signed-off-by line so that the people who will end
up applying it are CCed. That's at least Artem.
> Regards,
> gregor
>
> ---
> drivers/mtd/devices/m25p80.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 1924d24..06beb3f 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -873,6 +873,7 @@ static int __devinit m25p_probe(struct spi_device *spi)
> else
> flash->mtd.name = dev_name(&spi->dev);
> + flash->mtd.owner = THIS_MODULE;
> flash->mtd.type = MTD_NORFLASH;
> flash->mtd.writesize = 1;
> flash->mtd.flags = MTD_CAP_NORFLASH;
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-08 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 8:10 [PATCH] mtd: m25p80: fix missing MTD module owner Grégor Boirie
2012-10-08 13:09 ` Marek Vasut [this message]
2012-10-11 10:04 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210081509.44802.marex@denx.de \
--to=marex@denx.de \
--cc=dedekind1@gmail.com \
--cc=gregor.boirie@parrot.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.