Re: [Powertop] [RFC][PATCH 2/2] Convert powertop to use new report generator facility

[Sergey Senozhatsky <sergey.senozhatsky at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]

On (10/08/12 11:22), Chris Ferron wrote:
> 
> #1 I noticed that the scripts section of Software Settings in need of
> Tuning is missing. I see the nice header, but not data.
> #2 C0 active table cells are not aligned , and the CPU's are also not
> aligned correctly in the Processor Idle state report section.
> #3 I get some warning compiling, I know PowerTOP is not warning less,
> but would like to attempt to prevent adding more. (and fixing exiting
> ones of course)
> report/report-maker.cpp: In destructor ‘report_maker::~report_maker()’:
> report/report-maker.cpp:51:10: warning: deleting object of abstract
> class type ‘report_formatter’ which has non-virtual destructor will
> cause undefined behaviour [-Wdelete-non-virtual-dtor]
> report/report-maker.cpp: In member function ‘void
> report_maker::setup_report_formatter()’:
> report/report-maker.cpp:110:10: warning: deleting object of abstract
> class type ‘report_formatter’ which has non-virtual destructor will
> cause undefined behaviour [-Wdelete-non-virtual-dtor]
>


#3 is fixed already.

	-ss

 
> #4 report[c,h] should probable just go in your new sub/dir (report).
> #5 csv report has alignment issues for both the cpu Idle and Freq.
> Even if they are machine readable, they need to be easily parsed
> using open office or MS excel and look aligned with the http report.
> 
> other issues are small and can be attended to in the future, or have
> been already expressed.
> 
> Thanks
> -C
>