From: Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/nouveau: remove >1 sclass support from nouveau_parent_create_
Date: Tue, 9 Oct 2012 10:05:54 +1000 [thread overview]
Message-ID: <20121009000554.GB19660@turiel> (raw)
In-Reply-To: <20121008230208.GE3103-OI9uyE9O0yo@public.gmane.org>
On Tue, Oct 09, 2012 at 01:02:08AM +0200, Marcin Slusarz wrote:
> On Mon, Oct 08, 2012 at 11:06:46AM +1000, Ben Skeggs wrote:
> > On Mon, Oct 08, 2012 at 12:49:30AM +0200, Marcin Slusarz wrote:
> > > It's unused (only one codepath passes sclass at all and it's always one),
> > > broken (overwrites the same field, leaking previous one) and confusing.
> > It's only *currently* unused, I have WIP code in branches that uses it,
> > otherwise it wouldn't still exist :)
>
> Yeah, like _nouveau_parent_ctor :P
Point taken :P
>
> > I will take a look today at the claims it's broken, it wasn't at some
> > point but may have got busted along the way somehow.
>
> Oh, it chains them in list...
>
> /me hides.
Hehe :)
Ben.
>
> Marcin
prev parent reply other threads:[~2012-10-09 0:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 22:49 [PATCH] drm/nouveau: remove >1 sclass support from nouveau_parent_create_ Marcin Slusarz
[not found] ` <1349650171-25045-4-git-send-email-marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-08 1:06 ` Ben Skeggs
[not found] ` <20121008010646.GB4197-6RkuLLNOGXsZ315U/fw+0NvLeJWuRmrY@public.gmane.org>
2012-10-08 23:02 ` Marcin Slusarz
[not found] ` <20121008230208.GE3103-OI9uyE9O0yo@public.gmane.org>
2012-10-09 0:05 ` Ben Skeggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009000554.GB19660@turiel \
--to=skeggsb-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.