Re: [PATCH regression] dup3: Return an error when oldfd == newfd.

[Al Viro <viro@ZenIV.linux.org.uk>]

On Tue, Oct 09, 2012 at 03:27:43PM +0100, Richard W.M. Jones wrote:
> I have tested the attached patch to fix the dup3 regression.
> 
> Rich.
> 
> From 0944e30e12dec6544b3602626b60ff412375c78f Mon Sep 17 00:00:00 2001
> From: "Richard W.M. Jones" <rjones@redhat.com>
> Date: Tue, 9 Oct 2012 14:42:45 +0100
> Subject: [PATCH] dup3: Return an error when oldfd == newfd.
> 
> The following commit:
> 
>   commit fe17f22d7fd0e344ef6447238f799bb49f670c6f
>   Author: Al Viro <viro@zeniv.linux.org.uk>
>   Date:   Tue Aug 21 11:48:11 2012 -0400
> 
>     take purely descriptor-related stuff from fcntl.c to file.c
> 
> was supposed to be just code motion, but it dropped the following two
> lines:
> 
>   if (unlikely(oldfd == newfd))
>           return -EINVAL;

*grumble*
So it has; applied, will push to Linus.  But now I really want to check
if I'd lost anything else in those code moves (and you are right, it
was supposed to be just that).