From: Oleg Nesterov <oleg@redhat.com>
To: Andrey Wagin <avagin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [PATCH] [RFC] pidns: don't zap processes several times
Date: Tue, 9 Oct 2012 18:29:25 +0200 [thread overview]
Message-ID: <20121009162925.GA6517@redhat.com> (raw)
In-Reply-To: <CANaxB-w+KkhzTQVie=9PE8LJtazqvh+JducTcDmXvH+ZA4oO0A@mail.gmail.com>
On 10/08, Andrey Wagin wrote:
>
> 2012/10/7 Oleg Nesterov <oleg@redhat.com>:
> >
> > Perhaps we should MAX_PID_NS_LEVEL instead?
>
> Yes, we can.
>
> Could I just define MAX_PID_NS_LEVEL in a code:
> #define MAX_PID_NS_LEVEL ((PAGE_SIZE - offsetof(struct pid, numbers))
> / sizeof(struct upid))
Or even less. But looks reasonable.
> Or should it be added in a config?
Personally I think that "define" is fine, we can add config/sysctl
later if needed.
Hmm. This is off-topic, but...
create_pid_namespace:
unsigned int level = parent_pid_ns->level + 1;
ns->pid_cachep = create_pid_cachep(level + 1);
is it correct? is seems that only one "+ 1" is needed?
Oleg.
next prev parent reply other threads:[~2012-10-09 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 9:49 [PATCH] [RFC] pidns: don't zap processes several times Andrew Vagin
2012-10-07 10:20 ` Andrew Vagin
2012-10-07 19:01 ` Oleg Nesterov
2012-10-08 17:10 ` Andrey Wagin
2012-10-09 16:29 ` Oleg Nesterov [this message]
2012-10-09 17:41 ` Andrey Wagin
2012-10-09 17:50 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009162925.GA6517@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=segoon@openwall.com \
--cc=serge.hallyn@canonical.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.