From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Adil Mujeeb <mujeeb.adil@gmail.com>,
pavel@ucw.cz, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: winbond: wbusb: Fixed coding style issue
Date: Tue, 9 Oct 2012 09:46:14 -0700 [thread overview]
Message-ID: <20121009164614.GA17274@kroah.com> (raw)
In-Reply-To: <1349799738.2386.1.camel@joe-AO722>
On Tue, Oct 09, 2012 at 09:22:18AM -0700, Joe Perches wrote:
> On Tue, 2012-10-09 at 21:40 +0530, Adil Mujeeb wrote:
> > Repalces printk's with pr_debug
> []
> > diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> > index 0ca857a..48fe622 100644
> > --- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> > +++ b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> > @@ -79,18 +79,18 @@ static int wbsoft_add_interface(struct ieee80211_hw *dev,
> > static void wbsoft_remove_interface(struct ieee80211_hw *dev,
> > struct ieee80211_vif *vif)
> > {
> > - printk("wbsoft_remove interface called\n");
> > + pr_debug("wbsoft_remove interface called\n");
>
> It'd be more consistent to use
> pr_debug("%s called\n", __func__);
> everywhere.
>
> It might be even nicer to remove almost all of these.
>
Yes, "tracing" type debug calls like this should all be removed, now
that we have built-in function call tracing in the core kernel itself.
greg k-h
next prev parent reply other threads:[~2012-10-09 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 16:10 [PATCH] Staging: winbond: wbusb: Fixed coding style issue Adil Mujeeb
2012-10-09 16:22 ` Joe Perches
2012-10-09 16:46 ` Greg KH [this message]
2012-10-09 18:02 ` Adil Mujeeb
-- strict thread matches above, loose matches on Subject: below --
2012-10-10 10:35 Adil Mujeeb
2012-10-10 10:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009164614.GA17274@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.