Re: [PATCH v3 1/2] ACPI: Add early console framework for DBGP/DBG2.

[Konrad Rzeszutek Wilk <konrad@kernel.org>]

On Mon, Oct 08, 2012 at 03:24:12AM +0000, Zheng, Lv wrote:
> Hi,
> 
> This is my first time sending patch to the community, thanks for your suggestion.
> 
> > > + *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> > > +02111-1307  USA
> > Please remove the address.
> Done.
> 
> > > +static inline int acpi_table_parse_dbg2(acpi_early_console_handler
> > > +handler)
> > Why inline?
> Done.
> I was trying to eliminate ABI related callee/caller side generation as this function will be called only once.
> According to your suggestion, I removed the inline to make it a symbol.
> 
> > And somehow I am not able to find acpi_early_console_handler?
> It's in the header file along with other acpi table handlers.
> 
> > > +		pr_warn("DBG2 not present\n");
> > Um, pr_warn in an early printk driver? Perhaps pr_debug?
> Done.
> 
> > > +			if (handler(&devinfo, table_end)) {
> > 
> > Oh! it is a function! Perhaps call it 'func' or just use the raw decleration in the
> > arguments instead of using a typedef.
> This remains unmodified to keep the same style with other acpi table handlers.

OK. Perhaps a different name then? 'fnc_handler' ?

> 
> > > +	pr_info("early: DBG2 console %d detected: %04x:%04x.\n",
> > > +		info->port_index, info->port_type, info->port_subtype);
> Done.
> 
> Best regards/Lv Zheng
>