All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2] xfsprogs: report projid32 status in growfs output
Date: Wed, 10 Oct 2012 06:47:52 +1100	[thread overview]
Message-ID: <20121009194752.GM23644@dastard> (raw)
In-Reply-To: <5074792A.2080509@sandeen.net>

On Tue, Oct 09, 2012 at 02:21:14PM -0500, Eric Sandeen wrote:
> With the projid32 flag now in the FSGEOM ioctl results we
> can report projid32 status in xfs_growfs / xfs_info output,
> to match the mkfs.xfs output.
> 
> However, since the flag was only recently added to the kernel,
> we may get some incorrect reports of "projid32bit=0"
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> ... and I don't know how big a problem those incorrect reports
> might be ...

I doubt it will be a problem - the 32bit projid is pretty
self-contained, and we can still get the info from xfs_db if we
really need to confirm that it is set.

Code looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-10-09 19:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09 19:13 [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Eric Sandeen
2012-10-09 19:21 ` [PATCH 2/2] xfsprogs: report projid32 status in growfs output Eric Sandeen
2012-10-09 19:47   ` Dave Chinner [this message]
2012-10-09 19:48 ` [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Dave Chinner
2012-10-11  0:00 ` Eric Sandeen
2012-10-11  0:01   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121009194752.GM23644@dastard \
    --to=david@fromorbit.com \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.