From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] arm: vt8500: Convert irq.c for multiplatform integration
Date: Wed, 10 Oct 2012 08:35:05 +0000 [thread overview]
Message-ID: <201210100835.05898.arnd@arndb.de> (raw)
In-Reply-To: <1349856509-20480-1-git-send-email-linux@prisktech.co.nz>
On Wednesday 10 October 2012, Tony Prisk wrote:
> This patch converts arch-vt8500/irq.c to MULTI_IRQ_HANDLER and
> SPARSE_IRQ. IRQ domain is changed from legacy to linear.
>
> Also, remove legacy code in include/mach/entry-macro.S and
> include/mach/irq.h to prepare for multiplatform.
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Excellent!
Acked-by: Arnd Bergmann <arnd@arndb.de>
One small style comment for a preexisting issue I had not noticed before:
> static void vt8500_irq_mask(struct irq_data *d)
> {
> - struct vt8500_irq_priv *priv =
> - (struct vt8500_irq_priv *)(d->domain->host_data);
> + struct vt8500_irq_data *priv =
> + (struct vt8500_irq_data *)(d->domain->host_data);
host_data is a void pointer, so you don't need the type cast. Writing this
as
struct vt8500_irq_priv *priv = d->domain->host_data;
is both the common convention and easier to read.
Arnd
next prev parent reply other threads:[~2012-10-10 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 8:08 [RFC PATCH] arm: vt8500: Convert irq.c for multiplatform integration Tony Prisk
2012-10-10 8:35 ` Arnd Bergmann [this message]
2012-10-10 17:51 ` Tony Prisk
2012-10-10 17:54 ` Tony Prisk
2012-10-10 18:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210100835.05898.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.