From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLtAu-0000sE-GX for qemu-devel@nongnu.org; Wed, 10 Oct 2012 06:06:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLtAo-0005FD-ES for qemu-devel@nongnu.org; Wed, 10 Oct 2012 06:06:00 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:50002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLtAo-0005F1-7n for qemu-devel@nongnu.org; Wed, 10 Oct 2012 06:05:54 -0400 Received: by mail-we0-f173.google.com with SMTP id t11so207687wey.4 for ; Wed, 10 Oct 2012 03:05:53 -0700 (PDT) Date: Wed, 10 Oct 2012 12:05:51 +0200 From: "Edgar E. Iglesias" Message-ID: <20121010100551.GC18642@edde.se.axis.com> References: <1349812584-19551-1-git-send-email-aurelien@aurel32.net> <1349812584-19551-18-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349812584-19551-18-git-send-email-aurelien@aurel32.net> Subject: Re: [Qemu-devel] [PATCH v2 17/26] target-cris: rename helper flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On Tue, Oct 09, 2012 at 09:56:15PM +0200, Aurelien Jarno wrote: > Rename helper flags to the new ones. This is purely a mechanical change, > it's possible to use better flags by looking at the helpers. > > Cc: Edgar E. Iglesias > Signed-off-by: Aurelien Jarno > --- > target-cris/helper.h | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/target-cris/helper.h b/target-cris/helper.h > index 99fb326..fe12083 100644 > --- a/target-cris/helper.h > +++ b/target-cris/helper.h > @@ -10,19 +10,19 @@ DEF_HELPER_1(rfn, void, env); > DEF_HELPER_3(movl_sreg_reg, void, env, i32, i32) > DEF_HELPER_3(movl_reg_sreg, void, env, i32, i32) > > -DEF_HELPER_FLAGS_1(lz, TCG_CALL_PURE, i32, i32); > -DEF_HELPER_FLAGS_4(btst, TCG_CALL_PURE, i32, env, i32, i32, i32); > +DEF_HELPER_FLAGS_1(lz, TCG_CALL_NO_SE, i32, i32); btw, lz could be TCG_CALL_NO_RGSE like in the microblaze case. I guess the _CONST was missing from before... > +DEF_HELPER_FLAGS_4(btst, TCG_CALL_NO_SE, i32, env, i32, i32, i32); > > -DEF_HELPER_FLAGS_4(evaluate_flags_muls, TCG_CALL_PURE, i32, env, i32, i32, i32) > -DEF_HELPER_FLAGS_4(evaluate_flags_mulu, TCG_CALL_PURE, i32, env, i32, i32, i32) > -DEF_HELPER_FLAGS_5(evaluate_flags_mcp, TCG_CALL_PURE, i32, env, > +DEF_HELPER_FLAGS_4(evaluate_flags_muls, TCG_CALL_NO_SE, i32, env, i32, i32, i32) > +DEF_HELPER_FLAGS_4(evaluate_flags_mulu, TCG_CALL_NO_SE, i32, env, i32, i32, i32) > +DEF_HELPER_FLAGS_5(evaluate_flags_mcp, TCG_CALL_NO_SE, i32, env, > i32, i32, i32, i32) > -DEF_HELPER_FLAGS_5(evaluate_flags_alu_4, TCG_CALL_PURE, i32, env, > +DEF_HELPER_FLAGS_5(evaluate_flags_alu_4, TCG_CALL_NO_SE, i32, env, > i32, i32, i32, i32) > -DEF_HELPER_FLAGS_5(evaluate_flags_sub_4, TCG_CALL_PURE, i32, env, > +DEF_HELPER_FLAGS_5(evaluate_flags_sub_4, TCG_CALL_NO_SE, i32, env, > i32, i32, i32, i32) > -DEF_HELPER_FLAGS_3(evaluate_flags_move_4, TCG_CALL_PURE, i32, env, i32, i32) > -DEF_HELPER_FLAGS_3(evaluate_flags_move_2, TCG_CALL_PURE, i32, env, i32, i32) > +DEF_HELPER_FLAGS_3(evaluate_flags_move_4, TCG_CALL_NO_SE, i32, env, i32, i32) > +DEF_HELPER_FLAGS_3(evaluate_flags_move_2, TCG_CALL_NO_SE, i32, env, i32, i32) > DEF_HELPER_1(evaluate_flags, void, env) > DEF_HELPER_1(top_evaluate_flags, void, env) > > -- > 1.7.10.4 >