From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Felix Fietkau <nbd@openwrt.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3.7] mac80211: use ieee80211_free_txskb to fix possible skb leaks
Date: Wed, 10 Oct 2012 11:19:36 -0400 [thread overview]
Message-ID: <20121010151936.GB6247@tuxdriver.com> (raw)
In-Reply-To: <1349879153.4683.51.camel@jlt4.sipsolutions.net>
On Wed, Oct 10, 2012 at 04:25:53PM +0200, Johannes Berg wrote:
> On Wed, 2012-10-10 at 14:58 +0200, Felix Fietkau wrote:
> > On 2012-10-08 2:39 PM, Felix Fietkau wrote:
> > > A few places free skbs using dev_kfree_skb even though they're called
> > > after ieee80211_subif_start_xmit might have cloned it for tracking tx
> > > status. Use ieee80211_free_txskb here to prevent skb leaks.
> > >
> > > Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> > > Cc: stable@vger.kernel.org
> > Found a few more places that should use ieee80211_free_txskb, will send
> > a v2.
>
> John already applied this, no?
Yes, please send as a follow-on patch.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-10-10 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 12:39 [PATCH 3.7] mac80211: use ieee80211_free_txskb to fix possible skb leaks Felix Fietkau
2012-10-10 12:58 ` Felix Fietkau
2012-10-10 14:25 ` Johannes Berg
2012-10-10 15:19 ` John W. Linville [this message]
2012-10-10 15:27 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010151936.GB6247@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.