From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] console & omap-common/spl: Enable use of eserial
Date: Wed, 10 Oct 2012 16:53:36 +0200 [thread overview]
Message-ID: <201210101653.37024.marex@denx.de> (raw)
In-Reply-To: <20121010091028.01de813d@brick>
Dear Andrew Bradford,
> Dear Marek Vasut,
>
> On Thu, 27 Sep 2012 18:34:18 +0200
>
> Marek Vasut <marex@denx.de> wrote:
> > Dear Andrew Bradford,
> >
> > > Enable use of eserial devices for common and omap-common/spl.
> > >
> > > This probably isn't the right way to do this as the changes aren't
> > > needed for 'common' configurations, just for one case.
> > >
> > > Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
> > > ---
> > >
> > > arch/arm/cpu/armv7/omap-common/spl.c | 7 ++++++-
> > > common/console.c | 24
> > >
> > > ++++++++++++++++++++---- include/common.h |
> > > 5 +++++ 3 files changed, 31 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/arch/arm/cpu/armv7/omap-common/spl.c
> > > b/arch/arm/cpu/armv7/omap-common/spl.c index 4d1ac85..6258c0e 100644
> > > --- a/arch/arm/cpu/armv7/omap-common/spl.c
> > > +++ b/arch/arm/cpu/armv7/omap-common/spl.c
> > > @@ -210,7 +210,12 @@ void preloader_console_init(void)
> > >
> > > gd->flags |= GD_FLG_RELOC;
> > > gd->baudrate = CONFIG_BAUDRATE;
> > >
> > > - serial_init(); /* serial communications
> > > setup */
> > > + /* serial communications setup */
> > > +#ifdef CONFIG_SERIAL_MULTI
> > > + ESERIAL_FUNC(CONFIG_CONS_INDEX, init)();
> >
> > Uh, if you implement default_serial_console properly(), you won't
> > need this. Actually, I'm in the process of rolling out V2 of my
> > serial patchset, which will make your life much more easier. Can you
> > rebase the patchset on my series? I'll poke you about it.
>
> I see that your serial patches have made it into u-boot/next, should I
> rebase this patch set with the requested changes on top of u-boot/next
> and resubmit?
Yes
> Sorry, I'm not entirely clear on the role /next plays.
Simple. Merge window for current release is long closed, anything that goes into
next release is in /next. The /master branch is now only being tested and only
stabilization patches are accepted.
> Or is it recommended to rebase my changes on top of the tree I worked
> with before but with your serial patches applied? Or some other method?
Rebase on next please. Thanks!
> Thanks,
> Andrew
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-10 14:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 20:04 [U-Boot] [PATCH 0/6] am335x_evm: Enable UART{1,2,4,5} Andrew Bradford
2012-09-26 20:04 ` [U-Boot] [PATCH 1/6] am33xx: Enable UART{1,2,4,5} clocks Andrew Bradford
2012-09-27 12:48 ` Matt Porter
2012-09-27 16:13 ` Marek Vasut
2012-09-27 16:25 ` Tom Rini
2012-09-27 16:45 ` Marek Vasut
2012-09-27 17:07 ` Tom Rini
2012-09-27 17:11 ` Marek Vasut
2012-09-27 17:22 ` Tom Rini
2012-09-27 17:27 ` Marek Vasut
2012-09-27 17:53 ` Tom Rini
2012-10-20 0:25 ` Andrew Bradford
2012-10-20 17:48 ` Tom Rini
2012-10-20 18:57 ` Marek Vasut
2012-10-21 14:54 ` Tom Rini
2012-09-26 20:04 ` [U-Boot] [PATCH 2/6] am33xx: Enable UART{1,2,4,5} pin-mux Andrew Bradford
2012-09-27 12:49 ` Matt Porter
2012-09-26 20:04 ` [U-Boot] [PATCH 3/6] serial: Enable up to 6 eserial devices Andrew Bradford
2012-09-26 20:04 ` [U-Boot] [PATCH 4/6] console & omap-common/spl: Enable use of eserial Andrew Bradford
2012-09-27 16:34 ` Marek Vasut
[not found] ` <20121010091028.01de813d@brick>
2012-10-10 14:53 ` Marek Vasut [this message]
2012-10-10 16:00 ` Tom Rini
2012-09-26 20:04 ` [U-Boot] [PATCH 5/6] am33xx: Enable eserial device usage for ns16550 Andrew Bradford
2012-09-26 20:04 ` [U-Boot] [PATCH 6/6] am335x_evm: Enable use of UART{1,2,4,5} Andrew Bradford
2012-09-27 12:50 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210101653.37024.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.