From: Aaron Lu <aaron.lu@intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
Aaron Lu <aaron.lwe@gmail.com>
Subject: Re: [PATCH 2/2] [SCSI] sd: update sd to use the new pm callbacks
Date: Thu, 11 Oct 2012 16:10:19 +0800 [thread overview]
Message-ID: <20121011081018.GB1819@mint-spring.sh.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1210101433571.1170-100000@iolanthe.rowland.org>
On Wed, Oct 10, 2012 at 02:35:47PM -0400, Alan Stern wrote:
> On Wed, 10 Oct 2012, Aaron Lu wrote:
>
> > Update sd driver to use the callbacks defined in dev_pm_ops.
> >
> > sd_freeze is NULL, the bus level callback has taken care of quiescing
> > the device so there should be nothing needs to be done here.
> > Consequently, sd_thaw is not needed here either.
> >
> > Both suspend and poweroff shares the same routine sd_suspend, which will
> > sync flush and then stop the drive, this is the same as before.
> >
> > sd_runtime_suspend also uses sd_suspend, so when a scsi disk is runtime
> > suspended, it will be placed to stopped power state.
>
> This is not the same as before. The existing code does not spin down
> the disk during runtime suspend.
>
> Now maybe it should -- I don't know. The point is that this patch
> makes two separate changes, which is generally not a good idea.
Agree. Will seperate, thanks.
-Aaron
prev parent reply other threads:[~2012-10-11 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 7:28 [PATCH 0/2] Migrate SCSI drivers to use dev_pm_ops Aaron Lu
2012-10-10 7:28 ` [PATCH 1/2] [SCSI] pm: use callbacks from dev_pm_ops for scsi devices Aaron Lu
2012-10-10 18:32 ` Alan Stern
2012-10-11 8:09 ` Aaron Lu
2012-10-10 7:28 ` [PATCH 2/2] [SCSI] sd: update sd to use the new pm callbacks Aaron Lu
2012-10-10 18:35 ` Alan Stern
2012-10-11 8:10 ` Aaron Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011081018.GB1819@mint-spring.sh.intel.com \
--to=aaron.lu@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aaron.lwe@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.