From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Trepák Vilmos" <trepo@netcomga.sk>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Platform: hp-wmi: add rfkill support for integrated GPS
Date: Thu, 11 Oct 2012 13:34:15 +0100 [thread overview]
Message-ID: <20121011123415.GA6056@srcf.ucam.org> (raw)
In-Reply-To: <1349952660.1577.43.camel@pluto.netcomga.sk>
On Thu, Oct 11, 2012 at 12:51:00PM +0200, Trepák Vilmos wrote:
> @@ -663,6 +669,24 @@ static int __devinit hp_wmi_rfkill_setup
> goto register_bluetooth_error;
> }
>
> + if (wireless & 0x3) {
> + gps_rfkill = rfkill_alloc("hp-gps", &device->dev,
> + RFKILL_TYPE_GPS,
> + &hp_wmi_rfkill_ops,
> + (void *) HPWMI_GPS);
I don't think this bit is right - in this codepath, wireless is a mask,
so 0x3 would mean wifi and bluetooth, not gps. I'd expect gps to be 0x8.
The rest looks good, though.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-10-11 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 10:51 [PATCH] Platform: hp-wmi: add rfkill support for integrated GPS Trepák Vilmos
2012-10-11 12:34 ` Matthew Garrett [this message]
2012-10-11 13:15 ` Trepák Vilmos
2012-10-11 13:18 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011123415.GA6056@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=trepo@netcomga.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.