From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>,
Blue Swirl <blauwirbel@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used
Date: Thu, 11 Oct 2012 15:31:55 +0200 [thread overview]
Message-ID: <20121011133155.GA8983@redhat.com> (raw)
In-Reply-To: <1349962023-560-8-git-send-email-avi@redhat.com>
On Thu, Oct 11, 2012 at 03:27:03PM +0200, Avi Kivity wrote:
> vhost doesn't support guest iommus yet, indicate it to the user
> by gently depositing a core on their disk.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
Actually there is no problem. virtio bypasses an IOMMU,
so vhost works fine by writing into guest memory directly.
So I don't think we need this patch.
> ---
> hw/vhost.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/vhost.c b/hw/vhost.c
> index 0b4ac3f..cd5d9f5 100644
> --- a/hw/vhost.c
> +++ b/hw/vhost.c
> @@ -451,6 +451,8 @@ static void vhost_region_add(MemoryListener *listener,
> struct vhost_dev *dev = container_of(listener, struct vhost_dev,
> memory_listener);
>
> + assert(!memory_region_is_iommu(section.mr));
> +
> if (!vhost_section(section)) {
> return;
> }
> --
> 1.7.12
next prev parent reply other threads:[~2012-10-11 13:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 13:26 [Qemu-devel] [RFC v1 0/7] IOMMU support Avi Kivity
2012-10-11 13:26 ` [Qemu-devel] [RFC v1 1/7] memory: fix address space initialization/destruction Avi Kivity
2012-10-11 13:31 ` Paolo Bonzini
2012-10-11 13:33 ` Avi Kivity
2012-10-13 9:14 ` Blue Swirl
2012-10-11 13:26 ` [Qemu-devel] [RFC v1 2/7] memory: limit sections in the radix tree to the actual address space size Avi Kivity
2012-10-11 13:26 ` [Qemu-devel] [RFC v1 3/7] memory: iommu support Avi Kivity
2012-10-11 13:42 ` Paolo Bonzini
2012-10-11 13:45 ` Avi Kivity
2012-10-11 13:54 ` Paolo Bonzini
2012-10-11 13:57 ` Avi Kivity
2012-10-12 2:51 ` Benjamin Herrenschmidt
2012-10-15 16:54 ` Avi Kivity
2012-10-12 2:45 ` Benjamin Herrenschmidt
2012-10-13 9:30 ` Blue Swirl
2012-10-13 11:37 ` Benjamin Herrenschmidt
2012-10-11 14:29 ` Avi Kivity
2012-10-11 13:27 ` [Qemu-devel] [RFC v1 4/7] pci: switch iommu to using the memory API Avi Kivity
2012-10-11 13:53 ` Paolo Bonzini
2012-10-11 13:56 ` Avi Kivity
2012-10-13 9:13 ` Blue Swirl
2012-10-15 10:31 ` Avi Kivity
2012-10-11 13:27 ` [Qemu-devel] [RFC v1 5/7] i440fx: add an iommu Avi Kivity
2012-10-11 13:27 ` [Qemu-devel] [RFC v1 6/7] vfio: abort if an emulated iommu is used Avi Kivity
2012-10-11 13:27 ` [Qemu-devel] [RFC v1 7/7] vhost: " Avi Kivity
2012-10-11 13:31 ` Michael S. Tsirkin [this message]
2012-10-11 13:34 ` Avi Kivity
2012-10-11 13:44 ` Michael S. Tsirkin
2012-10-11 13:44 ` Avi Kivity
2012-10-11 14:35 ` Michael S. Tsirkin
2012-10-11 14:35 ` Avi Kivity
2012-10-11 15:34 ` Michael S. Tsirkin
2012-10-11 15:48 ` Avi Kivity
2012-10-11 19:38 ` Alex Williamson
2012-10-15 10:24 ` Avi Kivity
2012-10-15 8:44 ` liu ping fan
2012-10-15 10:32 ` Avi Kivity
2012-10-12 2:36 ` [Qemu-devel] [RFC v1 0/7] IOMMU support Benjamin Herrenschmidt
2012-10-15 10:45 ` Avi Kivity
2012-10-15 19:52 ` Benjamin Herrenschmidt
2012-10-16 9:30 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011133155.GA8983@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.