From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMKAw-0007A7-N3 for qemu-devel@nongnu.org; Thu, 11 Oct 2012 10:55:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMKAp-00079a-Rk for qemu-devel@nongnu.org; Thu, 11 Oct 2012 10:55:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMKAp-000794-HF for qemu-devel@nongnu.org; Thu, 11 Oct 2012 10:55:43 -0400 Date: Thu, 11 Oct 2012 16:46:56 +0200 From: "Michael S. Tsirkin" Message-ID: <20121011144656.GF8983@redhat.com> References: <20121011105705.GE5552@redhat.com> <20121011142122.GH3592@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121011142122.GH3592@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: agraf@suse.de, aliguori@us.ibm.com, juzhang@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, kraxel@redhat.com On Thu, Oct 11, 2012 at 10:21:22AM -0400, Jason Baron wrote: > On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > > > From: Jason Baron > > > > > > Add piix style acpi hotplug to q35. > > > > > > Signed-off-by: Jason Baron > > > > Something I don't understand here: this only handles hotplug > > of devices behind the root, no? > > Don't we need support for hotplug/hot remove of devices behind > > bridges? > > > > Yes, this only handles acpi hotplug of devices behind the root. I'm > trying to reach minimal set of q35 patches that we can build upon. I > think that this patch gives us at least the same functionality as piix > does. (Plus there is pcie hotplug). > > As you know, I have a proof of concept patch series providing a second > level of hotplug behind bridges. Unfortunately, it was based on the > static acpi tables, before Paolo made the hotplug table generation > dynamic. So it needs quite a bit of re-work. But I know that it should > work :) > > Thanks, > > -Jason Yes. Reason I ask is because q35 is adding bridges by default now. Would it be possible to only add them if requested on command line by user instead? I realize some guests expect devices at specific slots but this does not apply to bridges I think? It would also be nice to add comments explaining why specific slots were selected e.g. /* BSD XYZ fails to boot unless ahci is at alow 2 */ etc. Also - will adding this code now mean that when adding bridges we'll need to add compatibility code in bios/qemu in the future? -- MST