From: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Martin Peres <martin.peres-BktLLJ5BOkI@public.gmane.org>
Subject: Re: [PATCH] drm/nv50: wire up pll_calc hook
Date: Thu, 11 Oct 2012 19:36:02 +0200 [thread overview]
Message-ID: <20121011173602.GA4053@joi.lan> (raw)
In-Reply-To: <1349650171-25045-1-git-send-email-marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, Oct 08, 2012 at 12:49:27AM +0200, Marcin Slusarz wrote:
> Fixes crash during reclocking.
> Call Trace:
> pll_calc == NULL
> calc_pll
> calc_mclk
> nv50_pm_clocks_pre
> nouveau_pm_perflvl_set
> nouveau_pm_trigger
> nouveau_pm_profile_set
> nouveau_pm_set_perflvl
> dev_attr_store
> sysfs_write_file
> vfs_write
> sys_write
> system_call_fastpath
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>
> It's weird nobody noticed this... nva3+ code does not set this hook either,
> but there's no existing function to wire up...
>
And it seems to crash in the same way, see:
http://www.phoronix.com/image-viewer.php?id=ubuntu_1210_nouvre&image=ubuntu_nouveau_pointer_lrg
BTW, reclocking crashes without this patch:
https://gitorious.org/linux-nouveau-pm/linux-nouveau-pm/commit/f3ed9b23ee611891166da9bac792a22844217c7a
Applying this patch:
https://gitorious.org/linux-nouveau-pm/linux-nouveau-pm/commit/abdd905d2bf362d48c125fd7c556c54c7ae1cbb9
would be good too, because perflvl module option is useless without it.
Marcin
prev parent reply other threads:[~2012-10-11 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 22:49 [PATCH] drm/nv50: wire up pll_calc hook Marcin Slusarz
[not found] ` <1349650171-25045-1-git-send-email-marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-11 17:36 ` Marcin Slusarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011173602.GA4053@joi.lan \
--to=marcin.slusarz-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=martin.peres-BktLLJ5BOkI@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.