All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: [Powertop] [PATCH] clean up csv report formatter
Date: Thu, 11 Oct 2012 15:33:08 -0700	[thread overview]
Message-ID: <20121011223308.GA3045@swordfish.datadirect.datadirectnet.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3097 bytes --]

[PATCH] clean up csv report formatter

Do not re-define/re-implement unused basic formatter functions in csv reporter
(e.g. report_formatter_csv::finish_report()).


Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>

---

 src/report/report-formatter-csv.cpp | 40 -------------------------------------
 src/report/report-formatter-csv.h   |  8 --------
 2 files changed, 48 deletions(-)

diff --git a/src/report/report-formatter-csv.cpp b/src/report/report-formatter-csv.cpp
index 9b154b5..37ac86b 100644
--- a/src/report/report-formatter-csv.cpp
+++ b/src/report/report-formatter-csv.cpp
@@ -45,14 +45,6 @@ report_formatter_csv::report_formatter_csv()
 /* ************************************************************************ */
 
 void
-report_formatter_csv::finish_report()
-{
-	/* Do nothing special */
-}
-
-/* ************************************************************************ */
-
-void
 report_formatter_csv::add_doc_header()
 {
 	add_header(report_csv_header, 1);
@@ -75,22 +67,6 @@ report_formatter_csv::add_header(const char *header, int level)
 /* ************************************************************************ */
 
 void
-report_formatter_csv::begin_section(section_type stype)
-{
-	/* Do nothing special */
-}
-
-/* ************************************************************************ */
-
-void
-report_formatter_csv::end_section()
-{
-	/* Do nothing special */
-}
-
-/* ************************************************************************ */
-
-void
 report_formatter_csv::begin_table(table_type ttype)
 {
 	add_exact("\n");
@@ -163,14 +139,6 @@ report_formatter_csv::end_cell()
 /* ************************************************************************ */
 
 void
-report_formatter_csv::add_empty_cell()
-{
-	/* Do nothing special */
-}
-
-/* ************************************************************************ */
-
-void
 report_formatter_csv::begin_paragraph()
 {
 	text_start = result.length();
@@ -213,11 +181,3 @@ report_formatter_csv::escape_string(const char *str)
 
 	return res;
 }
-
-/* ************************************************************************ */
-
-void
-report_formatter_csv::set_cpu_number(int nr UNUSED)
-{
-	/* Do nothing */
-}
diff --git a/src/report/report-formatter-csv.h b/src/report/report-formatter-csv.h
index 8dd2976..8db9839 100644
--- a/src/report/report-formatter-csv.h
+++ b/src/report/report-formatter-csv.h
@@ -49,13 +49,8 @@ class report_formatter_csv: public report_formatter_string_base
 public:
 	report_formatter_csv();
 
-	void finish_report();
-
 	void add_header(const char *header, int level);
 
-	void begin_section(section_type stype);
-	void end_section();
-
 	void begin_table(table_type ttype);
 	void end_table();
 
@@ -64,13 +59,10 @@ public:
 
 	void begin_cell(cell_type ctype);
 	void end_cell();
-	void add_empty_cell();
 
 	void begin_paragraph();
 	void end_paragraph();
 
-	void set_cpu_number(int nr);
-
 private:
 	void add_doc_header();
 



                 reply	other threads:[~2012-10-11 22:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121011223308.GA3045@swordfish.datadirect.datadirectnet.com \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.