From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] FEC: Rework RX buffer init
Date: Fri, 12 Oct 2012 13:08:18 +0200 [thread overview]
Message-ID: <20121012130818.09c035eb@lilith> (raw)
In-Reply-To: <1349822613-26137-1-git-send-email-marex@denx.de>
Hi Marek,
On Wed, 10 Oct 2012 00:43:33 +0200, Marek Vasut <marex@denx.de> wrote:
> Rework the RX buffer init so that it's easier to understand.
> Firstly, allocate the whole RX buffer as one large continuous
> piece of memory. Also, drop all these writel() accessors used
> on the FEC RX DMA descriptor, since it's all flat bogus.
I'd like this commit message to be more usefully descriptive than "all
flat bogus". What exactly is bogus in it?
> Finally, this makes recoverable stalls of the FEC on i.MX28
> disappear completely.
Are both the single allocation change and the writel() change needed
for this?
Amicalement,
--
Albert.
prev parent reply other threads:[~2012-10-12 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 22:43 [U-Boot] [PATCH] FEC: Rework RX buffer init Marek Vasut
2012-10-12 11:08 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012130818.09c035eb@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.