Re: [PATCH v2] TPM: Provide a tpm_tis OF driver

[Jason Gunthorpe <jgunthorpe@obsidianresearch.com>]

On Wed, Oct 10, 2012 at 11:24:28AM -0500, Kent Yoder wrote:

>   Why change the structs to const here? This generates warnings for me:

I should have dropped this, I was added when I added the __devinitdata
annotations..

> > +
> > +static struct platform_driver tis_driver = {
> >  	.driver = {
> >  		.name = "tpm_tis",
> >  		.owner		= THIS_MODULE,
> >  		.pm		= &tpm_tis_pm,
> > +		.of_match_table = of_match_ptr(tis_of_platform_match),
> >  	},
> 
>   Patch v2 removes the ifdef around of_match_table, which now generates
> an error:

Yes, this update was following the style of other drivers. Obviously I
never thought to try this on x86 (only PPC), so I will try to setup a
compile for that as well and send v3.

I suspect this is simply a missing #include.

Regards,
Jason