From: Larry McVoy <lm@bitmover.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bruce Fields <bfields@fieldses.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Larry McVoy <lm@bitmover.com>
Subject: Re: kernel BUG at /build/buildd/linux-3.2.0/fs/lockd/clntxdr.c:226!
Date: Fri, 12 Oct 2012 19:30:00 -0700 [thread overview]
Message-ID: <20121013023000.GI23247@bitmover.com> (raw)
In-Reply-To: <5078D17C.9090002@panasas.com>
In BitKeeper, we wacked perror() to print out file, line. Saved us
a ton of debugging. Oh, and bk-version as well. That helps.
On Fri, Oct 12, 2012 at 07:27:08PM -0700, Boaz Harrosh wrote:
> On 10/12/2012 04:52 PM, Linus Torvalds wrote:
> > Guys, check this report from Larry out.
> >
> > Also, why the *HELL* is that a BUG_ON() in the first place? Who was
> > the less-than-gifted person who decided "if this thing can happen,
> > let's just kill the whole machine"?
> >
>
> Something is trivially weird
>
> fs/lockd/clntxdr.c:226 is in this static function:
> encode_nlm_stat()
>
> encode_nlm_stat() is called in two places
> static void nlm_xdr_enc_res(...)
> and
> static void nlm_xdr_enc_testres(...)
>
> But these two are not called anywhere. In-fact a Kernel wide grep
> returns a single occurrence of both
>
> I suspect the BUG_ON() belongs else where.
> Perhaps we should add __func__ to the BUG_ON macro exactly for times
> that source and Kernel get out of sync.
>
> Puzzled
> Boaz
--
---
Larry McVoy lm at bitmover.com http://www.bitkeeper.com
next prev parent reply other threads:[~2012-10-13 2:30 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121012211701.GA8301@bitmover.com>
2012-10-12 23:52 ` kernel BUG at /build/buildd/linux-3.2.0/fs/lockd/clntxdr.c:226! Linus Torvalds
2012-10-13 0:21 ` Larry McVoy
2012-10-13 1:02 ` Linus Torvalds
2012-10-13 1:36 ` Jim Rees
2012-10-13 1:45 ` Linus Torvalds
2012-10-13 21:31 ` Daniel Kahn Gillmor
2012-10-13 2:08 ` Boaz Harrosh
2012-10-13 2:28 ` Myklebust, Trond
2012-10-13 2:31 ` Larry McVoy
2012-10-13 2:52 ` Myklebust, Trond
2012-10-13 2:56 ` Larry McVoy
2012-10-13 3:05 ` Myklebust, Trond
2012-10-13 4:42 ` Myklebust, Trond
2012-10-14 1:42 ` Larry McVoy
2012-10-15 0:43 ` Bruce Fields
2012-10-15 4:38 ` Myklebust, Trond
2012-10-15 14:34 ` Larry McVoy
2012-10-15 18:02 ` Bruce Fields
2012-10-15 4:41 ` Myklebust, Trond
2012-10-15 12:11 ` Bruce Fields
2012-10-17 14:00 ` Bruce Fields
2012-10-14 19:39 ` Bruce Fields
2012-10-14 19:44 ` Linus Torvalds
2012-10-14 20:55 ` Chuck Lever
2012-10-14 21:05 ` Linus Torvalds
2012-10-14 22:32 ` Chuck Lever
2012-10-14 22:54 ` Linus Torvalds
2012-10-13 2:27 ` Boaz Harrosh
2012-10-13 2:30 ` Larry McVoy [this message]
2012-10-13 2:32 ` Myklebust, Trond
2012-10-13 2:39 ` Boaz Harrosh
2012-10-13 2:43 ` Larry McVoy
2012-10-14 19:43 ` Bruce Fields
2012-10-15 18:20 ` Boaz Harrosh
2012-10-13 2:37 ` Linus Torvalds
2012-10-15 8:05 George Spelvin
2012-10-15 12:19 ` Myklebust, Trond
2012-10-15 16:02 ` VDR User
2012-10-16 1:48 ` George Spelvin
2012-10-16 1:52 ` Larry McVoy
2012-10-16 3:46 ` Myklebust, Trond
2012-10-16 4:39 ` George Spelvin
2012-10-16 11:17 ` Jim Rees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013023000.GI23247@bitmover.com \
--to=lm@bitmover.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=bharrosh@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.