From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [RFC][PATCH] Small rework on report formatter side
Date: Sat, 13 Oct 2012 06:31:28 -0700 [thread overview]
Message-ID: <20121013133128.GA3041@swordfish> (raw)
In-Reply-To: 50781F22.3050805@samsung.com
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On (10/12/12 17:46), Igor Zhbanov wrote:
> He Sergey,
>
> Sergey Senozhatsky wrote:
>
>
> 1)
> - "Basic report_formatter::get_resul call\n"
> + "basic_report_formatter::get_result call\n"
>
oops.
[..]
> >+ virtual void end_paragraph() {};
> >+
> >+ /* For quad-colouring CPU tables in HTML */
> >+ virtual void set_cpu_number(int nr) {};
> >+};
>
> 2) You don't need semicolon after closing bracket in class member inline definition in C++.
>
ok.
AFAIK, it has been merged already, so I'll prepare fixes later (I'm in airport currently).
Thanks!
-ss
next reply other threads:[~2012-10-13 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 13:31 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-12 13:46 [Powertop] [RFC][PATCH] Small rework on report formatter side Igor Zhbanov
2012-10-11 21:55 Chris Ferron
2012-10-10 23:03 Sergey Senozhatsky
2012-10-10 18:13 Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013133128.GA3041@swordfish \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.