From: tupeng212 <tupeng212@gmail.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: alloc_heap_pages is low efficient with more CPUs
Date: Sat, 13 Oct 2012 15:20:06 +0800 [thread overview]
Message-ID: <2012101315200385948426@gmail.com> (raw)
In-Reply-To: CC9EC2C2.41A13%keir.xen@gmail.com
[-- Attachment #1.1: Type: text/plain, Size: 874 bytes --]
/* Allocate 2^@order contiguous pages. */
static struct page_info *alloc_heap_pages(
unsigned int zone_lo, unsigned int zone_hi,
unsigned int node, unsigned int order, unsigned int memflags)
{
cpus_clear(mask);
for ( i = 0; i < (1 << order); i++ )
{
if ( pg[i].u.free.need_tlbflush )
{
/* Add in extra CPUs that need flushing because of this page. */
cpus_andnot(extra_cpus_mask, cpu_online_map, mask);
tlbflush_filter(extra_cpus_mask, pg[i].tlbflush_timestamp);
cpus_or(mask, mask, extra_cpus_mask);
}
}
if ( unlikely(!cpus_empty(mask)) )
{
perfc_incr(need_flush_tlb_flush);
flush_tlb_mask(&mask);
}
return pg;
}
Is this equal to : in pg[1<<order-1].u.free.need_tlbflush, if we compute mask=0, then flush TLB mask ?
[-- Attachment #1.2: Type: text/html, Size: 2798 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-10-13 7:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 15:18 alloc_heap_pages is low efficient with more CPUs tupeng212
2012-10-11 15:41 ` Keir Fraser
2012-10-12 12:24 ` tupeng212
2012-10-12 22:39 ` Mukesh Rathor
2012-10-13 6:03 ` Keir Fraser
2012-10-13 7:20 ` tupeng212 [this message]
2012-10-13 8:59 ` Keir Fraser
[not found] <CC9EC91B.41A16%keir.xen@gmail.com>
2012-10-13 6:46 ` tupeng212
2012-10-13 8:59 ` Keir Fraser
2012-10-15 13:27 ` tupeng212
2012-10-15 15:45 ` Keir Fraser
2012-10-16 7:51 ` Jan Beulich
2012-10-16 8:03 ` Keir Fraser
2012-10-16 8:28 ` Jan Beulich
2012-10-16 8:53 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2012101315200385948426@gmail.com \
--to=tupeng212@gmail.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.