From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs pile 3
Date: Sat, 13 Oct 2012 12:04:55 -0400 [thread overview]
Message-ID: <20121013160455.GA32420@infradead.org> (raw)
In-Reply-To: <20121013160115.GS2616@ZenIV.linux.org.uk>
On Sat, Oct 13, 2012 at 05:01:15PM +0100, Al Viro wrote:
> You know, I'm in the middle of dealing with one such TODO. Yours, as it
> were. From six years ago. kernel_thread() unexporting. TODO comments
> of any form are routinely shat upon and ignored, especially when shuffled
> away into less read parts of the tree... ;-/
>
> I'd rather see it done fs-by-fs. Starting with something reasonably easy
> to test - minixfs would do nicely. Don't get me wrong - I'm all for
> burying ->truncate(); what I'm worried about is that we'll end up burying
> the warning about the reasons why vmtruncate() was a bad idea, leaving the
> functionality exactly as it used to be...
As mentioned I agree with the concern in principle. Let's start by
taking Marco's patches for filesystems that use vmtruncate but don't
actually implement ->truncate. There's a few I remember offhand, e.g.
procfs and ufs right now. Then we can do the actual work required ones
piece by piece.
next prev parent reply other threads:[~2012-10-13 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 0:20 [git pull] vfs pile 3 Al Viro
2012-10-13 7:20 ` Marco Stornelli
2012-10-13 7:51 ` Al Viro
2012-10-13 7:52 ` Marco Stornelli
2012-10-13 15:48 ` Christoph Hellwig
2012-10-13 16:01 ` Al Viro
2012-10-13 16:04 ` Christoph Hellwig [this message]
2012-10-13 17:07 ` Al Viro
2012-10-14 9:59 ` Marco Stornelli
-- strict thread matches above, loose matches on Subject: below --
2016-08-07 3:46 Al Viro
2016-08-07 14:00 ` Linus Torvalds
2016-12-23 0:03 Al Viro
2016-12-23 11:44 ` Al Viro
2018-06-04 1:12 [git pull] vfs, " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013160455.GA32420@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.