From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 07/22] adfs: drop vmtruncate
Date: Sat, 13 Oct 2012 12:20:15 -0400
Message-ID: <20121013162015.GD19899@infradead.org>
References: <506FE958.4070005@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	Anton Blanchard <anton@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-kernel@vger.kernel.org,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>
To: Marco Stornelli <marco.stornelli@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <506FE958.4070005@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

> @@ -57,8 +57,9 @@ static int adfs_write_begin(struct file *file, struct address_space *mapping,
>  				&ADFS_I(mapping->host)->mmu_private);
>  	if (unlikely(ret)) {
>  		loff_t isize = mapping->host->i_size;
> -		if (pos + len > isize)
> -			vmtruncate(mapping->host, isize);
> +		if ((pos + len > isize) &&
> +			inode_newsize_ok(mapping->host, isize) == 0)
> +			truncate_setsize(mapping->host, isize);

No need for the inode_newsize_ok check here.