Re: [PATCH 3/4] reset_resource: add wakeup source

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 20:18 Sat 13 Oct     , Sascha Hauer wrote:
> On Sat, Oct 13, 2012 at 03:49:21PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > This will allow to known the source of wakeup
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  common/reset_source.c  |   17 +++++++++++++++++
> >  include/reset_source.h |   11 +++++++++++
> >  2 files changed, 28 insertions(+)
> > 
> > diff --git a/common/reset_source.c b/common/reset_source.c
> > index ec1afc0..4791d29 100644
> > --- a/common/reset_source.c
> > +++ b/common/reset_source.c
> > @@ -34,11 +34,28 @@ void set_reset_source(enum reset_src_type st)
> >  }
> >  EXPORT_SYMBOL(set_reset_source);
> >  
> > +static const char * const wakeup_src_names[] = {
> > +	[WAKEUP_UKWNOWN] = "unknown",
> > +	[WAKEUP_POWER] = "power",
> > +	[WAKEUP_RTC] = "rtc",
> > +	[WAKEUP_TIMER] = "timer",
> > +	[WAKEUP_USER] = "user",
> > +	[WAKEUP_WOL] = "wakeup on lan",
> > +};
> 
> I'm unsure we need a second array for this. I mean RTC can't be seen as
> a reset source, but with a bit of good will the watchdog for example can
> be seen as a wakeup source. We have:
> 
> 	WAKEUP_POWER
> 	WAKEUP_RTC
> 	WAKEUP_TIMER
> 	WAKEUP_USER
> 	WAKEUP_WOL
> 	RESET_POWER
> 	RESET_RESET
> 	RESET_WATCHDOG
> 	RESET_WAKEUP
> 	RESET_JTAG
> 
> WAKEUP_POWER and RESET_POWER are duplicates, RESET_WAKEUP is just an
> indicator that we should look into the WAKEUP_* array. The rest are all
> mutually exclusive. So we would have:
for reset POWER mean inmy ming we gcc power up on the soc
not I plug the power

so it could be WKAEUP_POWER_UP

for RESET_WAKEUP I agree
> 
> 	WAKEUP_POWER
> 	WAKEUP_RTC
> 	WAKEUP_TIMER
> 	WAKEUP_USER
> 	WAKEUP_WOL
> 	WAKEUP_RESET
> 	WAKEUP_WATCHDOG
> 	WAKEUP_JTAG
> 
> Wouldn't that be better?
Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox