From: Greg KH <gregkh@linuxfoundation.org>
To: Sangho Yi <antiroot@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: Staging: CSR: made corrections on the indentation errors
Date: Sun, 14 Oct 2012 04:26:52 -0700 [thread overview]
Message-ID: <20121014112652.GA542@kroah.com> (raw)
In-Reply-To: <1350213611-19806-1-git-send-email-antiroot@gmail.com>
On Sun, Oct 14, 2012 at 08:20:11PM +0900, Sangho Yi wrote:
> Originally there were a lot mis-indentation, so I made changes to use
> only the tabs (no spaces) on indenting code.
> - Still, the typedef struct ... tells warning message on checkpatch.pl.
Yes, we shouldn't be using a typedef, but why did you change the typedef
itself:
> -typedef struct
> -{
> - u32 sec;
> - u16 msec;
> +typedef struct _CsrTimeUtc {
> + u32 sec;
> + u16 msec;
> } CsrTimeUtc;
Why add the _CsrTimeUtc here? That's not really needed, right?
thanks,
greg k-h
prev parent reply other threads:[~2012-10-14 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 11:20 [PATCH] Drivers: Staging: CSR: made corrections on the indentation errors Sangho Yi
2012-10-14 11:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121014112652.GA542@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=antiroot@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.