From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: George Spelvin <linux@horizon.com>, linux-ext4@vger.kernel.org
Subject: Re: metadata_csum set but no space in dir leaf for checksum
Date: Sun, 14 Oct 2012 10:55:08 -0400 [thread overview]
Message-ID: <20121014145508.GC6207@thunk.org> (raw)
In-Reply-To: <65D4536C-0F58-4A26-A562-B665EC6CBBB2@dilger.ca>
On Sun, Oct 14, 2012 at 12:43:47AM -0600, Andreas Dilger wrote:
>
> This means there was an existing directory block that was completely full and
> could not have the checksum added. It isn't harmful, the chance of having
> silent corruption in this specific block is very small.
Was this a freshly created ext4 file system with the metadata_csum
checksum, or was this a previously existing ext4 file system where the
metadata_csum feature was added later?
I've pushed an update to the e2fsprogs repository which allows htree
and "ls -c" to actually show us the directory leaf block checksums.
Previously, they were hidden, which means that it's hard to tell
whether a directory had all of its directory blocks properly
checksummed or not.
> The message itself should be quieted though, since there isn't anything to be
> helped by printing it continuously. I guess there is something missing in
> e2fsck that it doesn't add a checksum to this block, however.
Either that, or somehow there is a case where the directory tail
containing the checksum is getting overwritten, or a directory block
isn't getting a checksum after a htree node split. The e2fsprogs
changes will hopefully make it easier for us to figure out what is
going on.
- Ted
next prev parent reply other threads:[~2012-10-14 14:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 5:05 metadata_csum set but no space in dir leaf for checksum George Spelvin
2012-10-14 6:43 ` Andreas Dilger
2012-10-14 7:56 ` George Spelvin
2012-10-14 14:55 ` Theodore Ts'o [this message]
2012-10-14 17:40 ` George Spelvin
[not found] <20121017195130.GA29138@blackbox.djwong.org>
[not found] ` <1BE5D8B7-A3C7-4556-B553-F2016174F475@dilger.ca>
2012-10-17 21:21 ` Darrick J. Wong
[not found] <20121017233209.7938.qmail@science.horizon.com>
2012-10-24 1:43 ` Darrick J. Wong
2012-10-24 4:12 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121014145508.GC6207@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux@horizon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.