Re: [PATCH] fsfreeze: tell hung_task about processes put to sleep

[Dave Chinner <david@fromorbit.com>]

On Mon, Oct 15, 2012 at 12:24:59PM +0900, Fernando Luis Vazquez Cao wrote:
> On 2012/10/13 10:06, Dave Chinner wrote:
> >On Fri, Oct 12, 2012 at 06:47:32PM +0900, Fernando Luis Vázquez Cao wrote:
> >>Any process attempting to write to a frozen filesystem uninterruptibly and
> >>unkillably waits for the filesystem to be thawed. This wait is of unbounded
> >>length. Ignore such waits in the hung_task detector.
> >Filesystems should not be frozen for long enough to trigger the hung
> >task detector under normal usage. IMO, if you are freezing a
> >filesystem for that long, then you're either doing something wrong
> >or something has gone wrong, and in either case I think we should be
> >emitting warnings...
> 
> The problem is that in production systems situations where
> a filesystem remains brozen for long periods are not uncommon.
> A typical example is as follows: the control daemon or script that
> controls the freeze/thaw using the fsfreeze ioctls dies, the next

There's your problem. Fix that, don't turn off useful warnings that
indicate something has gone wrong.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html