From: Greg KH <gregkh@linuxfoundation.org>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: "Tu, Xiaobing" <xiaobing.tu@intel.com>,
"ccross@android.com" <ccross@android.com>,
"davej@redhat.com" <davej@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"rusty@rustcorp.com.au" <rusty@rustcorp.com.au>,
"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"Zhang, Di" <di.zhang@intel.com>,
"Ma, Xindong" <xindong.ma@intel.com>,
"Zuo, Alex" <alex.zuo@intel.com>
Subject: Re: Fix memory leak in binder--version2
Date: Mon, 15 Oct 2012 16:58:36 -0700 [thread overview]
Message-ID: <20121015235836.GA3214@kroah.com> (raw)
In-Reply-To: <CAMP5Xgfo3u5QoKmkOpCyxHaEkCScWwKFDLnfQMH3mevcrF7aJQ@mail.gmail.com>
On Mon, Oct 15, 2012 at 04:55:21PM -0700, Arve Hjønnevåg wrote:
> On Mon, Oct 15, 2012 at 3:52 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Oct 15, 2012 at 07:20:01AM +0000, Tu, Xiaobing wrote:
> >> After enabling kmemleak and run monkey, following memleak is reported:
> >> unreferenced object 0xeed27f80 (size 64):
> >> comm "Binder_8", pid 641, jiffies 4294946341 (age 2275.810s)
> >> hex dump (first 32 bytes):
> >> 4f dd 00 00 84 7f d2 ee 84 7f d2 ee 01 00 00 00 O...............
> >> 00 00 00 00 00 00 00 00 00 aa 4c d7 00 00 00 00 ..........L.....
> >> backtrace:
> >> [<c184fabc>] kmemleak_alloc+0x3c/0xa0
> >> [<c12f391e>] kmem_cache_alloc_trace+0x9e/0x180
> >> [<c1668bb5>] binder_thread_write+0xcf5/0x23a0
> >> [<c166b091>] binder_ioctl+0x1f1/0x530
> >> [<c130dcf6>] do_vfs_ioctl+0x86/0x5e0
> >> [<c130e282>] sys_ioctl+0x32/0x60
> >> [<c1872e01>] syscall_call+0x7/0xb
> >> [<ffffffff>] 0xffffffff
> >>
> >> The work item in async_todo list is not freed when binder released.
> >> Also the async transaction should also be freed in binder_release_work.
> >>
> >> Signed-off-by: Leon Ma <xindong.ma@intel.com>
> >> Signed-off-by: Di Zhang <di.zhang@intel.com>
> >> ---
> >> drivers/staging/android/binder.c | 6 ++++++
> >> 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > Nice fix, but next time can you at least use scripts/get_maintainer.pl
> > to figure out who to send this to? I'll queue it up soon, but it took
> > akpm to point me at this for me to notice it.
>
> This patch was just pointer out to me as well. I have a similar fix
> queued up at https://android-review.googlesource.com/#/c/43801/ that
> is still being tested. It fixes this leak and a theoretical leak of
> death notification objects.
Ok, should I hold off applying this patch and wait for your patch
instead?
thanks,
greg k-h
next prev parent reply other threads:[~2012-10-15 23:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 7:03 Fix memory leak in binder Tu, Xiaobing
2012-10-15 7:20 ` Fix memory leak in binder--version2 Tu, Xiaobing
2012-10-15 22:52 ` Greg KH
2012-10-15 23:55 ` Arve Hjønnevåg
2012-10-15 23:58 ` Greg KH [this message]
2012-10-16 0:32 ` [PATCH 1/2] Staging: android: binder: Fix memory leak on thread/process exit Arve Hjønnevåg
2012-10-16 0:32 ` [PATCH 2/2] Staging: android: binder: Allow using highmem for binder buffers Arve Hjønnevåg
2012-10-16 7:12 ` Greg KH
2012-10-16 7:11 ` [PATCH 1/2] Staging: android: binder: Fix memory leak on thread/process exit Greg KH
2012-10-16 22:45 ` Arve Hjønnevåg
2012-10-22 20:00 ` Greg KH
2012-10-23 0:58 ` Arve Hjønnevåg
2012-10-23 3:12 ` Greg KH
2012-10-16 0:39 ` Fix memory leak in binder--version2 Arve Hjønnevåg
2012-10-16 7:11 ` Greg KH
2012-10-16 22:29 ` [PATCH 1/4] Staging: android: binder: Add some missing binder_stat_br calls Arve Hjønnevåg
2012-10-16 22:29 ` [PATCH 2/4] Staging: android: binder: Add some tracepoints Arve Hjønnevåg
2012-10-16 22:29 ` [PATCH 3/4] Staging: android: binder: Fix memory leak on thread/process exit Arve Hjønnevåg
2012-10-16 22:29 ` [PATCH 4/4] Staging: android: binder: Allow using highmem for binder buffers Arve Hjønnevåg
2012-10-16 22:33 ` Fix memory leak in binder--version2 Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015235836.GA3214@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alex.zuo@intel.com \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=davej@redhat.com \
--cc=di.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=xiaobing.tu@intel.com \
--cc=xindong.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.