From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: tytso@mit.edu, wenqing.lz@taobao.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Remove code duplication in ext4_get_block_write_nolock()
Date: Tue, 16 Oct 2012 10:36:21 +0800 [thread overview]
Message-ID: <20121016023621.GA5274@gmail.com> (raw)
In-Reply-To: <1350328009-22740-2-git-send-email-anatol.pomozov@gmail.com>
On Mon, Oct 15, 2012 at 12:06:49PM -0700, Anatol Pomozov wrote:
> 729f52c6be51013 introduced function ext4_get_block_write_nolock() that
> is very similar to _ext4_get_block(). Eliminate code duplication
> by passing different flags to _ext4_get_block()
>
> Tested: xfs tests
>
> Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
Good catch. you can add:
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
next prev parent reply other threads:[~2012-10-16 2:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 19:06 [PATCH 1/2] Use 'inode' variable that is already dereferenced Anatol Pomozov
2012-10-15 19:06 ` [PATCH 2/2] ext4: Remove code duplication in ext4_get_block_write_nolock() Anatol Pomozov
2012-10-15 19:14 ` Anatol Pomozov
2012-10-16 2:37 ` Zheng Liu
2012-10-16 2:36 ` Zheng Liu [this message]
2012-11-08 20:08 ` Theodore Ts'o
2012-11-09 17:29 ` Theodore Ts'o
2012-11-09 17:51 ` Anatol Pomozov
2012-10-16 2:28 ` [PATCH 1/2] Use 'inode' variable that is already dereferenced Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016023621.GA5274@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=anatol.pomozov@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.