From: "Theodore Ts'o" <tytso@mit.edu>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RESEND] [PATCH 1/2] random: make it possible to enable debugging without rebuild
Date: Mon, 15 Oct 2012 23:43:15 -0400 [thread overview]
Message-ID: <20121016034315.GC17446@thunk.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1210152340390.14002@pobox.suse.cz>
On Mon, Oct 15, 2012 at 11:42:55PM +0200, Jiri Kosina wrote:
> The module parameter that turns debugging mode (which basically means
> printing a few extra lines during runtime) is in '#if 0' block. Forcing
> everyone who would like to see how entropy is behaving on his system to
> rebuild seems to be a little bit too harsh.
>
> If we were concerned about speed, we could potentially turn 'debug' into a
> static key, but I don't think it's necessary.
>
> Drop the '#if 0' block to allow using the 'debug' parameter without rebuilding.
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Applied to the random tree, thanks.
- Ted
prev parent reply other threads:[~2012-10-16 3:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 14:39 [PATCH 1/2] random: make it possible to enable debugging without rebuild Jiri Kosina
2012-10-08 14:40 ` [PATCH 2/2] random: fix debug format strings Jiri Kosina
2012-10-15 21:43 ` [RESEND] " Jiri Kosina
2012-10-16 3:43 ` Theodore Ts'o
2012-10-08 19:45 ` [PATCH 1/2] random: make it possible to enable debugging without rebuild Joe Perches
2012-10-15 21:42 ` [RESEND] " Jiri Kosina
2012-10-16 3:43 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016034315.GC17446@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.