From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/4] drm/i915: ILK also needs that last fix Date: Tue, 16 Oct 2012 09:16:23 +0200 Message-ID: <20121016071623.GD5753@phenom.ffwll.local> References: <1349318064-22051-1-git-send-email-ben@bwidawsk.net> <1349318064-22051-3-git-send-email-ben@bwidawsk.net> <20121015185922.GA5753@phenom.ffwll.local> <20121015202141.00007429@unknown> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 2ABC89E775 for ; Tue, 16 Oct 2012 00:15:23 -0700 (PDT) Received: by mail-wg0-f41.google.com with SMTP id ds1so280868wgb.0 for ; Tue, 16 Oct 2012 00:15:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20121015202141.00007429@unknown> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Oct 15, 2012 at 08:21:41PM -0700, Ben Widawsky wrote: > On Mon, 15 Oct 2012 20:59:22 +0200 > Daniel Vetter wrote: > > > On Wed, Oct 03, 2012 at 07:34:23PM -0700, Ben Widawsky wrote: > > > That fix was the disable render deptch cache pipeline flush > > > > > > Signed-off-by: Ben Widawsky > > > > I've stumbled over the same one, but my docs here suggest i965g/gm45 > > need it, too: > > > > http://cgit.freedesktop.org/~danvet/drm/commit/?h=ilk-wa-pile&id=37c4c82b8cdbcf5adccad97f0b45747ba37ed659 > > > > Have you checked whether we don't need this on ivb/vlv/hsw, too? > > I did check whether the windows driver does it for those platforms, and > the answer is no. So the answer to your question is maybe because who > knows what exists in some other doc somewhere in the metaverse. I think > this is a good enough start though since it seems SNB was definitely a > bit buggier than IVB. Yeah, I've noticed while checking w/as that they're not consistently named on older platforms. E.g. the above definitely exists on eaglelake, too, but named slightly different. So the w/a db doesn't pick up all uses. Hoooray! > > Also, for w/a patches based on the vpg w/a database, please include > > the vpg w/a name tag both in the commit message and in a code comment > > somewhere. > > Good idea. If you're okay with longer commit message subjects, I'd even > suggest putting it there to make it even a bit easier to search for. Yeah, I'm fine with putting it into the commit head, I've put it there myself. If the w/a only affects one platform we could try to squeeze the platform name into the headline, too. But having to read the commit message for that doesn't really hurt, either. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch