From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: IVB-eDP regression with on latest git Date: Tue, 16 Oct 2012 10:03:13 +0200 Message-ID: <20121016080313.GJ5753@phenom.ffwll.local> References: <507A6735.90102@fisher-privat.net> <507AB4E7.1010300@fisher-privat.net> <507C5EF5.4010607@fisher-privat.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id C5FD89E79D for ; Tue, 16 Oct 2012 01:02:12 -0700 (PDT) Received: by mail-we0-f177.google.com with SMTP id u50so3733992wey.36 for ; Tue, 16 Oct 2012 01:02:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <507C5EF5.4010607@fisher-privat.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Oleksij Rempel Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Oct 15, 2012 at 09:07:33PM +0200, Oleksij Rempel wrote: > I'll repost it, looks like last message got lost. > > Am 14.10.2012 14:49, schrieb Oleksij Rempel: > >Am 14.10.2012 10:55, schrieb Daniel Vetter: > >>On Sun, Oct 14, 2012 at 9:18 AM, Oleksij Rempel > >> wrote: > >>>With latest kernel (vanilla/master, or intel.drm-next) i do not have > >>>image > >>>on build in screen (eDP). Hardware Asus Zenbook UX32A. Vendor: 0x8086, > >>>Device: 0x0166, Revision: 0x09 (??) > >>>Is it know issue? > >> > >>Nope, this is a new one. Can you grab the dmesg with drm.debug=0xe of > >>the broken kernel please? Also, a bisect usually helps a lot, too. > >> > >>Thanks, Daniel > >> > > > > > >I can't access this laptop with broken kernel. > > > >The patch caused this regression is: > >commit 2477367083b3eaa97f87993ab26627a02f350551 > >Author: Chris Wilson > >Date: Wed Sep 26 16:48:30 2012 +0100 > > > > drm/i915: Try harder to complete DP training pattern 1 > > > > In commit cdb0e95bf571dccc1f75fef9bdad21b167ef0b37 > > Author: Keith Packard > > Date: Tue Nov 1 20:00:06 2011 -0700 > > > > drm/i915: Try harder during dp pattern 1 link training > > > > extra passes were made to retry the same voltage and then retry a full > > clock reset. However, as coverity pointed out, we never tried the full > > clock reset as we broke out of the loop early. > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Damien Lespiau > > > > > >Reverting it makes laptop work again. Ok, I've reverted this in -fixes, we need to think a bit more about our dp link training for -next. Thanks a lot for reporting and bisecting this regression. Yours, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch