From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fluxbox: select xmodmap
Date: Tue, 16 Oct 2012 19:24:01 +0200 [thread overview]
Message-ID: <20121016192401.04d2eaf1@skate> (raw)
In-Reply-To: <1350370149-2876-1-git-send-email-yegorslists@googlemail.com>
On Tue, 16 Oct 2012 08:49:09 +0200, yegorslists at googlemail.com wrote:
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_FLUXBOX
> depends on BR2_PACKAGE_XORG7
> depends on BR2_INSTALL_LIBSTDCPP
> select BR2_PACKAGE_XLIB_LIBX11
> + select BR2_PACKAGE_XAPP_XMODMAP
> help
> The Fluxbox lightweight window manager for X
When a dependency like this is a runtime dependency, I generally like
to have a short comment on top of it. It's kind of likely that someone
will read fluxbox.mk, not see xmodmap in FLUXBOX_DEPENDENCIES, and
therefore wonder why this "select" is around. For sure, Git history is
here, but I think something like:
# Runtime dependency, needed by startup script
select BR2_PACKAGE_XAPP_XMODMAP
Doesn't harm too much and can be quite useful in the future.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-16 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 6:49 [Buildroot] [PATCH] fluxbox: select xmodmap yegorslists at googlemail.com
2012-10-16 17:24 ` Thomas Petazzoni [this message]
2012-10-16 19:33 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016192401.04d2eaf1@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.