Re: [PATCH] xfrm: use ISO C standard for array in linux/xfrm.h

[Steffen Klassert <steffen.klassert@secunet.com>]

On Tue, Oct 16, 2012 at 05:42:33PM +0200, nicolas.dichtel@6wind.com wrote:
> From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> 
> Use the ISO C standard compliant form instead of the gcc extension.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
>  include/uapi/linux/xfrm.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h
> index 28e493b..6a6a605 100644
> --- a/include/uapi/linux/xfrm.h
> +++ b/include/uapi/linux/xfrm.h
> @@ -30,7 +30,7 @@ struct xfrm_sec_ctx {
>  	__u8	ctx_alg;
>  	__u16	ctx_len;
>  	__u32	ctx_sid;
> -	char	ctx_str[0];
> +	char	ctx_str[];

Hm, what's the benefit of such a change? The kernel source is full
of these foo[0] type arrays. I don't see a reason to change this
just for xfrm.