From: Borislav Petkov <bp@amd64.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Tony Luck <tony.luck@intel.com>, X86-ML <x86@kernel.org>,
EDAC devel <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH -v2 3/6] x86, RAS: Convert mce-inject module to debugfs
Date: Wed, 17 Oct 2012 22:02:22 +0200 [thread overview]
Message-ID: <20121017200222.GA32230@aftab.osrc.amd.com> (raw)
In-Reply-To: <m2fw5csytg.fsf@firstfloor.org>
On Wed, Oct 17, 2012 at 12:06:35PM -0700, Andi Kleen wrote:
> Borislav Petkov <bp@amd64.org> writes:
>
> > From: Borislav Petkov <borislav.petkov@amd.com>
> >
> > This is a module which is used for debugging MCE decoding paths so its
> > userspace interface should go to debugfs, where it belongs conceptually.
> >
> > While at it, add a warning to the Kconfig text that this interface is
> > unstable and no userspace scripts should rely all too much on it.
>
> Nack. You broke mce-test/mce-inject, aka existing userland which is not
> allowed in Linux.
WTF? Have you actually even looked at the patch?
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-10-17 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 14:52 [PATCH -v2 0/6] AMD MCE injection improvs Borislav Petkov
2012-10-16 14:52 ` [PATCH -v2 1/6] x86, RAS: Add a barebones RAS subtree Borislav Petkov
2012-10-16 14:52 ` [PATCH -v2 2/6] x86, RAS: Move AMD MCE injection code into ras/ Borislav Petkov
2012-10-16 14:52 ` [PATCH -v2 3/6] x86, RAS: Convert mce-inject module to debugfs Borislav Petkov
2012-10-16 15:41 ` Joe Perches
2012-10-16 16:39 ` Borislav Petkov
2012-10-17 19:06 ` Andi Kleen
2012-10-17 20:02 ` Borislav Petkov [this message]
2012-10-16 14:52 ` [PATCH -v2 4/6] x86, RAS: Add function enabling direct writes to MCE MSRs Borislav Petkov
2012-10-16 17:59 ` Joe Perches
2012-10-16 14:52 ` [PATCH -v2 5/6] x86, RAS: Add attributes needed for HW injection Borislav Petkov
2012-10-16 14:52 ` [PATCH -v2 6/6] x86, RAS: Add an injector function Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017200222.GA32230@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=andi@firstfloor.org \
--cc=borislav.petkov@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.