All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [mac80211-next:wip 19/37] include/uapi/linux/nl80211.h:3101:1: error: expected identifier before
Date: Wed, 17 Oct 2012 23:35:20 +0000	[thread overview]
Message-ID: <20121017233520.GA16929@localhost> (raw)
In-Reply-To: <507ebd61.LoCS32J+GZFlvQsJ%fengguang.wu@intel.com>

Hi Bing,

On Wed, Oct 17, 2012 at 10:30:49AM -0700, Bing Zhao wrote:
> Hi Fengguang,
> 
> > > FYI, kernel build failed on
> > >
> > > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git wip
> > > head:   1e503ffb2c3ee288fd15a25cab14c9c074850e04
> 
> It compiled fine against this HEAD.

Yes.

> > > commit: 1fe89458a90b7de19ab1a4bbf96c5c298d31a30a [19/37] {nl,cfg}80211: add a flags word to scan
> > requests
> 
> This commit is the first patch (1/5) of "add scan flags support" series.
> It adds a placeholder for nl80211_scan_flags. 3/5 and 4/5 add actual flags to it.

But that placeholder is not a valid C construct and breaks kernel build ..

> So, you have to get the whole patchset to compile.

When preparing/organizing patches, every step of the patchset should
be able to build and boot fine. That will make it friendly to bisect.

Thanks,
Fengguang

  parent reply	other threads:[~2012-10-17 23:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 14:14 [mac80211-next:wip 19/37] include/uapi/linux/nl80211.h:3101:1: error: expected identifier before '}' Fengguang Wu
2012-10-17 15:55 ` [mac80211-next:wip 19/37] include/uapi/linux/nl80211.h:3101:1: error: expected identifier before Sam Leffler
2012-10-17 17:30 ` Bing Zhao
2012-10-17 23:35 ` Fengguang Wu [this message]
2012-10-17 23:53 ` Bing Zhao
2012-10-18  0:07 ` Sam Leffler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121017233520.GA16929@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.