All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [shaggy:loop_v3 16/22] drivers/block/loop.c:217:6: sparse: symbol 'lo_rw_aio_complete' was not decla
Date: Thu, 18 Oct 2012 03:10:06 +0000	[thread overview]
Message-ID: <20121018031006.GK21995@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20121017154411.GA21995@yliu-dev.sh.intel.com>

Hi Zach,

FYI, there are new sparse warnings show up in

tree:   git://github.com/kleikamp/linux-shaggy loop_v3
head:   d6e600319940e6015af553f1515cee9d53a3ced9
commit: c6aadd9b8fd4039534075531b06c8dc263f27c9d [16/22] loop: use aio to perform io on the underlying file

+ drivers/block/loop.c:217:6: sparse: symbol 'lo_rw_aio_complete' was not declared. Should it be static?
  drivers/block/loop.c:270:38: sparse: incorrect type in argument 2 (different address spaces)
  drivers/block/loop.c:270:38:    expected char const [noderef] <asn:1>*<noident>
  drivers/block/loop.c:270:38:    got unsigned char [usertype] *buf

vim +217 drivers/block/loop.c

73285082 Ken Chen         2007-05-08  201  	set_capacity(lo->lo_disk, x);
7035b5df Dmitry Monakhov  2011-11-16  202  	return 0;
^1da177e Linus Torvalds   2005-04-16  203  }
^1da177e Linus Torvalds   2005-04-16  204  
^1da177e Linus Torvalds   2005-04-16  205  static inline int
^1da177e Linus Torvalds   2005-04-16  206  lo_do_transfer(struct loop_device *lo, int cmd,
^1da177e Linus Torvalds   2005-04-16  207  	       struct page *rpage, unsigned roffs,
^1da177e Linus Torvalds   2005-04-16  208  	       struct page *lpage, unsigned loffs,
^1da177e Linus Torvalds   2005-04-16  209  	       int size, sector_t rblock)
^1da177e Linus Torvalds   2005-04-16  210  {
^1da177e Linus Torvalds   2005-04-16  211  	if (unlikely(!lo->transfer))
^1da177e Linus Torvalds   2005-04-16  212  		return 0;
^1da177e Linus Torvalds   2005-04-16  213  
^1da177e Linus Torvalds   2005-04-16  214  	return lo->transfer(lo, cmd, rpage, roffs, lpage, loffs, size, rblock);
^1da177e Linus Torvalds   2005-04-16  215  }
^1da177e Linus Torvalds   2005-04-16  216  
c6aadd9b From: Zach Brown 2012-10-15 @217  void lo_rw_aio_complete(u64 data, long res)
c6aadd9b From: Zach Brown 2012-10-15  218  {
c6aadd9b From: Zach Brown 2012-10-15  219  	struct bio *bio = (struct bio *)(uintptr_t)data;
c6aadd9b From: Zach Brown 2012-10-15  220  
c6aadd9b From: Zach Brown 2012-10-15  221  	if (res > 0)
c6aadd9b From: Zach Brown 2012-10-15  222  		res = 0;
c6aadd9b From: Zach Brown 2012-10-15  223  	else if (res < 0)
c6aadd9b From: Zach Brown 2012-10-15  224  		res = -EIO;
c6aadd9b From: Zach Brown 2012-10-15  225  

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

  parent reply	other threads:[~2012-10-18  3:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 15:44 [shaggy:loop_v3 16/22] drivers/block/loop.c:219:20: warning: cast to pointer from integer of differe Yuanhan Liu
2012-10-17 16:29 ` [shaggy:loop_v3 16/22] drivers/block/loop.c:219:20: warning: cast to pointer from integer of dif Dave Kleikamp
2012-10-17 17:52 ` Zach Brown
2012-10-18  2:18 ` Yuanhan Liu
2012-10-18  2:40 ` Asias He
2012-10-18  2:52 ` Fengguang Wu
2012-10-18  2:59 ` Asias He
2012-10-18  3:10 ` Yuanhan Liu [this message]
2012-10-18  3:19 ` [shaggy:loop_v3 16/22] drivers/block/loop.c:239:2: error: implicit declaration of function 'aio_kern Yuanhan Liu
2012-10-18 19:32 ` [shaggy:loop_v3 16/22] drivers/block/loop.c:239:2: error: implicit declaration of function 'aio_ Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121018031006.GK21995@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.