Re: [PATCH] arago-tisdk-image: Create image that builds Sitara SDK filesystem

[Denys Dmytriyenko <denys@ti.com>]

On Thu, Oct 18, 2012 at 03:16:39AM +0000, Cooper Jr., Franklin wrote:
> 
> 
> -----Original Message-----
> From: Maupin, Chase 
> Sent: Friday, October 12, 2012 9:58 PM
> To: Franklin S. Cooper Jr; meta-arago@arago-project.org
> Cc: Cooper Jr., Franklin
> Subject: RE: [meta-arago] [PATCH] arago-tisdk-image: Create image that builds Sitara SDK filesystem
> 
> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- 
> > bounces@arago-project.org] On Behalf Of Franklin S. Cooper Jr
> > Sent: Friday, October 12, 2012 1:07 AM
> > To: meta-arago@arago-project.org
> > Cc: Cooper Jr., Franklin
> > Subject: [meta-arago] [PATCH] arago-tisdk-image: Create image that 
> > builds Sitara SDK filesystem
> > 
> > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > ---
> >  .../recipes-core/images/arago-tisdk-image.bb       |   21
> > ++++++++++++++++++++
> >  1 files changed, 21 insertions(+), 0 deletions(-)  create mode 100644 
> > meta-arago-distro/recipes-core/images/arago-
> > tisdk-image.bb
> > 
> > diff --git a/meta-arago-distro/recipes-core/images/arago-tisdk-
> > image.bb b/meta-arago-distro/recipes-core/images/arago-tisdk-
> > image.bb
> > new file mode 100644
> > index 0000000..e9e6781
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-core/images/arago-tisdk-image.bb
> > @@ -0,0 +1,21 @@
> > +# Arago TI SDK base image
> > +# gives you an image with Qt/E and other common packages shared
> > by all TI SDKs.
> > +
> > +require arago-image.inc
> > +PR_append = "-arago0"
> 
> Why are you appending the PR?
> 
> Franklin: Its something that I added a few months when I had a concern about 
> the arago-image.inc file but I never properly addressed.
> I am going to send an updated patch . Essentially I am going to add INC_PR = 
> "r0" to arago-image.inc and in this recipe replace PR_append with PR = 
> "${INC_PR}.1".
> http://www.openembedded.org/wiki/Styleguide talks a little bit about this.

That's something I wanted to comment on as well... There are no PV or PR for 
image recipes, as that doesn't make much sense. Images have special handling, 
they are deployed and not packaged, with a specially defined names. Moreover, 
do_rootfs will always run when you bitbake the image recipe. So, drop any PR, 
INC_PR etc. from image recipes.

-- 
Denys