From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent Date: Thu, 18 Oct 2012 14:58:07 -0700 Message-ID: <20121018215807.GO13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-3-git-send-email-mhocko@suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=wRE42eXMU2vU/1HGj9MX8ZaxSBTMqbochMf2P65Q924=; b=B6Qkonn6BfevtEbRZPsuN230cYbr3SgKrHsPjUlzBayj5FW+/3HmXb7lGuEC/3O7OP G61YKiIZ2jF05Uh5clNSy4PGYUPuqiS/uBR+2WYTJUx2W76PzQuhkkKUeYMpvuaRVTmf wslqYPSe/GVzlY6JWw9hcStO4wX4QpEHiYQS7jgf3jRjW7vl036RrwWp2v81AaxvrlGC B7mNASD+UMVmw1glPDn95NI6bonKbfUfMhS2FvKEWjRJSVxiMuxAU6kXaksQQwbf2eFa 6bWvZgLnUkPLQUV9EExs82HXW7EuOH/a3mr9uuDo0oCD+jkIfi1Nsx6xUTXINtfM4Imk 336A== Content-Disposition: inline In-Reply-To: <1350480648-10905-3-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh On Wed, Oct 17, 2012 at 03:30:44PM +0200, Michal Hocko wrote: > The root cgroup cannot be destroyed so we never hit it idown the > mem_cgroup_pre_destroy path and mem_cgroup_force_empty_write shouldn't > even try to do anything if called for the root. > > This means that mem_cgroup_move_parent doesn't have to bother with the > root cgroup and it can assume it can always move charges upwards. > > Signed-off-by: Michal Hocko Reviewed-by: Tejun Heo Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx192.postini.com [74.125.245.192]) by kanga.kvack.org (Postfix) with SMTP id 3471C6B0044 for ; Thu, 18 Oct 2012 17:58:12 -0400 (EDT) Received: by mail-da0-f41.google.com with SMTP id i14so4302020dad.14 for ; Thu, 18 Oct 2012 14:58:11 -0700 (PDT) Date: Thu, 18 Oct 2012 14:58:07 -0700 From: Tejun Heo Subject: Re: [PATCH 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent Message-ID: <20121018215807.GO13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-3-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350480648-10905-3-git-send-email-mhocko@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh On Wed, Oct 17, 2012 at 03:30:44PM +0200, Michal Hocko wrote: > The root cgroup cannot be destroyed so we never hit it idown the > mem_cgroup_pre_destroy path and mem_cgroup_force_empty_write shouldn't > even try to do anything if called for the root. > > This means that mem_cgroup_move_parent doesn't have to bother with the > root cgroup and it can assume it can always move charges upwards. > > Signed-off-by: Michal Hocko Reviewed-by: Tejun Heo Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755595Ab2JRV6N (ORCPT ); Thu, 18 Oct 2012 17:58:13 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:44600 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753268Ab2JRV6M (ORCPT ); Thu, 18 Oct 2012 17:58:12 -0400 Date: Thu, 18 Oct 2012 14:58:07 -0700 From: Tejun Heo To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh Subject: Re: [PATCH 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent Message-ID: <20121018215807.GO13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-3-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350480648-10905-3-git-send-email-mhocko@suse.cz> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 17, 2012 at 03:30:44PM +0200, Michal Hocko wrote: > The root cgroup cannot be destroyed so we never hit it idown the > mem_cgroup_pre_destroy path and mem_cgroup_force_empty_write shouldn't > even try to do anything if called for the root. > > This means that mem_cgroup_move_parent doesn't have to bother with the > root cgroup and it can assume it can always move charges upwards. > > Signed-off-by: Michal Hocko Reviewed-by: Tejun Heo Thanks. -- tejun