From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 4/6] cgroups: forbid pre_destroy callback to fail Date: Thu, 18 Oct 2012 15:46:06 -0700 Message-ID: <20121018224606.GS13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-5-git-send-email-mhocko@suse.cz> <20121018224148.GR13370@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=wj4ZITQnRGYI2tMHIu6BCScsfPAt61viaDgHspKtLYg=; b=nkF2qHMnwQgYuKtMIgkg5cDW51IlF5y/C3fvPyXdDev1WPFxxwohmCu1551qqIVIhw Cf6Rue/bMnncxkcJw9hxmBjGTK4YMmfnIV/JX0fvD4pDYTx8PbCJ4unrh/1zx3AMOSql Ar1j+oWGkRQnKy0a7M9RyuGRP9BPs1o7HYGlJgJuHCtXZgiwB/ZkgncejKmn23k0vLiV 7ocsoDgB7flaPEg/atm4XQnr8cL5kVAkPM2noBka5ja4pdS0LZAU1G6gNEIIOXyAR/r3 mJ68d1Ap8HTS71FHpMzLu/7kS/Vn4/ZUPsFQXGkJPskSCN5oDbCDRbChFfmELyLoa7s5 JhCw== Content-Disposition: inline In-Reply-To: <20121018224148.GR13370-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh On Thu, Oct 18, 2012 at 03:41:48PM -0700, Tejun Heo wrote: > Note that the patch is broken in a couple places but it does show the > general direction. I'd prefer if patch #3 simply makes pre_destroy() > return 0 and drop __DEPRECATED_clear_css_refs from mem_cgroup_subsys. > Then, I can pull the branch in and drop all the unnecessary cruft. But you need the locking change for further memcg cleanup. To avoid interlocked pulls from both sides, I think it's okay to push this one with the rest of memcg changes. I can do the cleanup on top of this whole series, but please do drop .__DEPRECATED_clear_css_refs from memcg. Acked-by: Tejun Heo Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx128.postini.com [74.125.245.128]) by kanga.kvack.org (Postfix) with SMTP id DC1CF6B0062 for ; Thu, 18 Oct 2012 18:46:10 -0400 (EDT) Received: by mail-pa0-f41.google.com with SMTP id fa10so9883265pad.14 for ; Thu, 18 Oct 2012 15:46:10 -0700 (PDT) Date: Thu, 18 Oct 2012 15:46:06 -0700 From: Tejun Heo Subject: Re: [PATCH 4/6] cgroups: forbid pre_destroy callback to fail Message-ID: <20121018224606.GS13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-5-git-send-email-mhocko@suse.cz> <20121018224148.GR13370@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121018224148.GR13370@google.com> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh On Thu, Oct 18, 2012 at 03:41:48PM -0700, Tejun Heo wrote: > Note that the patch is broken in a couple places but it does show the > general direction. I'd prefer if patch #3 simply makes pre_destroy() > return 0 and drop __DEPRECATED_clear_css_refs from mem_cgroup_subsys. > Then, I can pull the branch in and drop all the unnecessary cruft. But you need the locking change for further memcg cleanup. To avoid interlocked pulls from both sides, I think it's okay to push this one with the rest of memcg changes. I can do the cleanup on top of this whole series, but please do drop .__DEPRECATED_clear_css_refs from memcg. Acked-by: Tejun Heo Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410Ab2JRWqM (ORCPT ); Thu, 18 Oct 2012 18:46:12 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:55679 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755008Ab2JRWqK (ORCPT ); Thu, 18 Oct 2012 18:46:10 -0400 Date: Thu, 18 Oct 2012 15:46:06 -0700 From: Tejun Heo To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh Subject: Re: [PATCH 4/6] cgroups: forbid pre_destroy callback to fail Message-ID: <20121018224606.GS13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-5-git-send-email-mhocko@suse.cz> <20121018224148.GR13370@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121018224148.GR13370@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 18, 2012 at 03:41:48PM -0700, Tejun Heo wrote: > Note that the patch is broken in a couple places but it does show the > general direction. I'd prefer if patch #3 simply makes pre_destroy() > return 0 and drop __DEPRECATED_clear_css_refs from mem_cgroup_subsys. > Then, I can pull the branch in and drop all the unnecessary cruft. But you need the locking change for further memcg cleanup. To avoid interlocked pulls from both sides, I think it's okay to push this one with the rest of memcg changes. I can do the cleanup on top of this whole series, but please do drop .__DEPRECATED_clear_css_refs from memcg. Acked-by: Tejun Heo Thanks. -- tejun