From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 5/6] memcg: make mem_cgroup_reparent_charges non failing Date: Thu, 18 Oct 2012 15:48:07 -0700 Message-ID: <20121018224807.GT13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-6-git-send-email-mhocko@suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=6Vf78MAEPy5TvvcvhAlOuaCfXNz/qnWGeqJ1rYpm61w=; b=ZHIzYjS6QJnZXUsbiSdSmMWJYbrMKhpl41brqP7KQSQa/Qq1u+Z5fk2tP7kX1ehxGD Xj06WasGMen0VYv0SiA6CcZUWS80GW2fcReoFp1V6srSGQNaShDXNlD+GQRuIn9u9fgy G/GjPA6TAoFg4y8cEgwM3Pl9Quowj5PT3OEKK3Gd3NMpUb3mZPr9vAEGQkfIc8vaQCEo h01fH68w7n6oL6oI2ggGCDO4Pccy0urmrYHFglvlwQPeRjW0WSNJaGnC+zKgGFsJvu1l oFIa7vk451tFpCcg6teNLU5SZpeUp4jsqzj/U/Fj2sYx4mbXuEvbDEursxcur+RQoZ6M X5Zg== Content-Disposition: inline In-Reply-To: <1350480648-10905-6-git-send-email-mhocko@suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh On Wed, Oct 17, 2012 at 03:30:47PM +0200, Michal Hocko wrote: > Now that pre_destroy callbacks are called from within cgroup_lock and > the cgroup has been checked to be empty without any children then there > is no other way to fail. > mem_cgroup_pre_destroy doesn't have to take a reference to memcg's css > because all css' are marked dead already. > > Signed-off-by: Michal Hocko Reviewed-by: Tejun Heo Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx161.postini.com [74.125.245.161]) by kanga.kvack.org (Postfix) with SMTP id EDF226B0068 for ; Thu, 18 Oct 2012 18:48:11 -0400 (EDT) Received: by mail-pa0-f41.google.com with SMTP id fa10so9884456pad.14 for ; Thu, 18 Oct 2012 15:48:11 -0700 (PDT) Date: Thu, 18 Oct 2012 15:48:07 -0700 From: Tejun Heo Subject: Re: [PATCH 5/6] memcg: make mem_cgroup_reparent_charges non failing Message-ID: <20121018224807.GT13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-6-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350480648-10905-6-git-send-email-mhocko@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh On Wed, Oct 17, 2012 at 03:30:47PM +0200, Michal Hocko wrote: > Now that pre_destroy callbacks are called from within cgroup_lock and > the cgroup has been checked to be empty without any children then there > is no other way to fail. > mem_cgroup_pre_destroy doesn't have to take a reference to memcg's css > because all css' are marked dead already. > > Signed-off-by: Michal Hocko Reviewed-by: Tejun Heo Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org