From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TPIIu-0004Dv-FM
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 15:32:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TPIIt-0002CL-DR
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 15:32:20 -0400
Received: from hall.aurel32.net ([88.191.126.93]:41292)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TPIIt-0002C6-6v
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 15:32:19 -0400
Date: Fri, 19 Oct 2012 21:32:17 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20121019193217.GD22247@ohm.aurel32.net>
References: <5055A16F.4040303@redhat.com>
	<1347826033-4330-1-git-send-email-vapier@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1347826033-4330-1-git-send-email-vapier@gentoo.org>
Subject: Re: [Qemu-devel] [PATCH v2] allow make {dist,
 }clean work w/out configure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mike Frysinger <vapier@gentoo.org>
Cc: qemu-devel@nongnu.org

On Sun, Sep 16, 2012 at 04:07:13PM -0400, Mike Frysinger wrote:
> There's no reason to require configure to run before running a clean
> target, so check MAKECMDGOALS before.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> v2
> 	- handle edge cases
> 
>  Makefile |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 1cd5bc8..0a37369 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -14,9 +14,11 @@ config-host.mak: $(SRC_PATH)/configure
>  	@sed -n "/.*Configured with/s/[^:]*: //p" $@ | sh
>  else
>  config-host.mak:
> +ifneq ($(filter-out %clean,$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail))
>  	@echo "Please call configure before running make!"
>  	@exit 1
>  endif
> +endif
>  
>  GENERATED_HEADERS = config-host.h trace.h qemu-options.def
>  ifeq ($(TRACE_BACKEND),dtrace)
> @@ -398,7 +400,9 @@ qemu-doc.dvi qemu-doc.html qemu-doc.info qemu-doc.pdf: \
>  
>  # Add a dependency on the generated files, so that they are always
>  # rebuilt before other object files
> +ifneq ($(filter-out %clean,$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail))
>  Makefile: $(GENERATED_HEADERS)
> +endif
>  
>  # Include automatically generated dependency files
>  # Dependencies in Makefile.objs files come from our recursive subdir rules

Thanks, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net